8.2.1 proposal

CHANGELOG.md

@@ -27,7 +27,8 @@ release.
 </tr>
 <tr>
     <td valign="top">
-<b><a href="doc/changelogs/CHANGELOG_V8.md#8.2.0">8.2.0</a></b><br/>
+<b><a href="doc/changelogs/CHANGELOG_V8.md#8.2.1">8.2.1</a></b><br/>
+<a href="doc/changelogs/CHANGELOG_V8.md#8.2.0">8.2.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V8.md#8.1.4">8.1.4</a><br/>
 <a href="doc/changelogs/CHANGELOG_V8.md#8.1.3">8.1.3</a><br/>
 <a href="doc/changelogs/CHANGELOG_V8.md#8.1.2">8.1.2</a><br/>

doc/changelogs/CHANGELOG_V8.md

@@ -6,6 +6,7 @@
 </tr>
 <tr>
 <td>
+<a href="#8.2.1">8.2.1</a><br/>
 <a href="#8.2.0">8.2.0</a><br/>
 <a href="#8.1.4">8.1.4</a><br/>
 <a href="#8.1.3">8.1.3</a><br/>
@@ -27,6 +28,21 @@
   * [io.js](CHANGELOG_IOJS.md)
   * [Archive](CHANGELOG_ARCHIVE.md)
 
+<a id="8.2.1"></a>
+## 2017-07-20, Version 8.2.1 (Current), @fishrock123
+
+### Notable changes
+
+* **http**: Writes no longer abort if the Socket is missing.
+* **process, async_hooks**: Avoid problems when `triggerAsyncId` is `undefined`.
+* **zlib**: Streams no longer attempt to process data when destroyed.
+
+### Commits
+
+* [[`8d426bbeec`](https://github.com/nodejs/node/commit/8d426bbeec)] - **http**: do not abort if socket is missing (Matteo Collina) [#14387](https://github.com/nodejs/node/pull/14387)
+* [[`302c19b006`](https://github.com/nodejs/node/commit/302c19b006)] - **process**: triggerAsyncId can be undefined (Matteo Collina) [#14387](https://github.com/nodejs/node/pull/14387)
+* [[`6fce1a314e`](https://github.com/nodejs/node/commit/6fce1a314e)] - **zlib**: check if the stream is destroyed before push (Matteo Collina) [#14330](https://github.com/nodejs/node/pull/14330)
+
 <a id="8.2.0"></a>
 ## 2017-07-19, Version 8.2.0 (Current), @fishrock123
 

lib/_http_outgoing.js

@@ -633,7 +633,7 @@ OutgoingMessage.prototype.write = function write(chunk, encoding, callback) {
 function write_(msg, chunk, encoding, callback, fromEnd) {
   if (msg.finished) {
     var err = new Error('write after end');
-    nextTick(msg.socket[async_id_symbol],
+    nextTick(msg.socket && msg.socket[async_id_symbol],
              writeAfterEndNT.bind(msg),
              err,
              callback);

lib/internal/process/next_tick.js

@@ -281,7 +281,7 @@ function setupNextTick() {
     if (process._exiting)
       return;
 
-    if (triggerAsyncId === null) {
+    if (!Number.isSafeInteger(triggerAsyncId) || triggerAsyncId <= 0) {
       triggerAsyncId = async_hooks.initTriggerId();
     }
 

lib/zlib.js

@@ -431,6 +431,9 @@ Zlib.prototype._processChunk = function _processChunk(chunk, flushFlag, cb) {
     if (self._hadError)
       return;
 
+    if (self.destroyed)
+      return;
+
     var have = availOutBefore - availOutAfter;
     assert(have >= 0, 'have should not go down');
 

src/node_version.h

@@ -26,7 +26,7 @@
 #define NODE_MINOR_VERSION 2
 #define NODE_PATCH_VERSION 1
 
-#define NODE_VERSION_IS_RELEASE 0
+#define NODE_VERSION_IS_RELEASE 1
 
 #ifndef NODE_STRINGIFY
 #define NODE_STRINGIFY(n) NODE_STRINGIFY_HELPER(n)

test/async-hooks/test-internal-nexttick-default-trigger.js

@@ -26,6 +26,11 @@ internal.nextTick(null, common.mustCall(function() {
   assert.strictEqual(async_hooks.triggerAsyncId(), rootAsyncId);
 }));
 
+// internal default
+internal.nextTick(undefined, common.mustCall(function() {
+  assert.strictEqual(async_hooks.triggerAsyncId(), rootAsyncId);
+}));
+
 // internal
 internal.nextTick(rootAsyncId + 1, common.mustCall(function() {
   assert.strictEqual(async_hooks.triggerAsyncId(), rootAsyncId + 1);

test/parallel/test-http-outgoing-message-inheritance.js

@@ -0,0 +1,32 @@
+'use strict';
+
+const common = require('../common');
+const { OutgoingMessage } = require('http');
+const { Writable } = require('stream');
+const assert = require('assert');
+
+// check that OutgoingMessage can be used without a proper Socket
+// Fixes: https://github.com/nodejs/node/issues/14386
+// Fixes: https://github.com/nodejs/node/issues/14381
+
+class Response extends OutgoingMessage {
+  constructor() {
+    super({ method: 'GET', httpVersionMajor: 1, httpVersionMinor: 1 });
+  }
+
+  _implicitHeader() {}
+}
+
+const res = new Response();
+const ws = new Writable({
+  write: common.mustCall((chunk, encoding, callback) => {
+    assert(chunk.toString().match(/hello world/));
+    setImmediate(callback);
+  })
+});
+
+res.socket = ws;
+ws._httpMessage = res;
+res.connection = ws;
+
+res.end('hello world');

test/parallel/test-http-server-response-standalone.js

@@ -0,0 +1,27 @@
+'use strict';
+
+const common = require('../common');
+const { ServerResponse } = require('http');
+const { Writable } = require('stream');
+const assert = require('assert');
+
+// check that ServerResponse can be used without a proper Socket
+// Fixes: https://github.com/nodejs/node/issues/14386
+// Fixes: https://github.com/nodejs/node/issues/14381
+
+const res = new ServerResponse({
+  method: 'GET',
+  httpVersionMajor: 1,
+  httpVersionMinor: 1
+});
+
+const ws = new Writable({
+  write: common.mustCall((chunk, encoding, callback) => {
+    assert(chunk.toString().match(/hello world/));
+    setImmediate(callback);
+  })
+});
+
+res.assignSocket(ws);
+
+res.end('hello world');

test/parallel/test-http-server-write-after-end.js

@@ -0,0 +1,27 @@
+'use strict';
+
+const common = require('../common');
+const http = require('http');
+const assert = require('assert');
+
+// Fix for https://github.com/nodejs/node/issues/14368
+
+const server = http.createServer(handle);
+
+function handle(req, res) {
+  res.on('error', common.mustCall((err) => {
+    assert.strictEqual(err.message, 'write after end');
+    server.close();
+  }));
+
+  res.write('hello');
+  res.end();
+
+  setImmediate(common.mustCall(() => {
+    res.write('world');
+  }));
+}
+
+server.listen(0, common.mustCall(() => {
+  http.get(`http://localhost:${server.address().port}`);
+}));

test/parallel/test-zlib-destroy-pipe.js

@@ -0,0 +1,21 @@
+'use strict';
+
+const common = require('../common');
+const zlib = require('zlib');
+const { Writable } = require('stream');
+
+// verify that the zlib transform does not error in case
+// it is destroyed with data still in flight
+
+const ts = zlib.createGzip();
+
+const ws = new Writable({
+  write: common.mustCall((chunk, enc, cb) => {
+    setImmediate(cb);
+    ts.destroy();
+  })
+});
+
+const buf = Buffer.allocUnsafe(1024 * 1024 * 20);
+ts.end(buf);
+ts.pipe(ws);