-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: remove newReturn for Module._resolveLookupPaths #14642
Conversation
The method Module._resolveLookupPaths's third parameter retNew is always true.
@nodejs/ctc ... any thoughts on this one? This is a |
The reason I added this awhile back was for backwards compatibility with userland since there were people accessing this "private" function directly and the new return value type would break their code. I do not know if this is still an issue today or not, you'd have to survey. I think at least Google had a project that used this function? Perhaps @ChALkeR can perform a search for us? |
I think so. |
Thanks for review. I will update the PR with deprecation cycle later. |
Ping @JacksonTian |
Ping @JacksonTian do you still want to pursue this? |
Sorry. I am too busy to do it. Close it first, i will deal with it later. |
The method Module._resolveLookupPaths's third parameter retNew
is always true.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)