Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: remove newReturn for Module._resolveLookupPaths #14642

Closed
wants to merge 1 commit into from

Conversation

JacksonTian
Copy link
Contributor

@JacksonTian JacksonTian commented Aug 5, 2017

The method Module._resolveLookupPaths's third parameter retNew
is always true.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

The method Module._resolveLookupPaths's third parameter retNew
is always true.
@nodejs-github-bot nodejs-github-bot added module Issues and PRs related to the module subsystem. repl Issues and PRs related to the REPL subsystem. labels Aug 5, 2017
@jasnell
Copy link
Member

jasnell commented Aug 5, 2017

@nodejs/ctc ... any thoughts on this one? This is a _-prefixed method but there's still a non-zero chance that this could break something somewhere. Should we take the argument through a deprecation cycle first?

@mscdex
Copy link
Contributor

mscdex commented Aug 5, 2017

The reason I added this awhile back was for backwards compatibility with userland since there were people accessing this "private" function directly and the new return value type would break their code. I do not know if this is still an issue today or not, you'd have to survey. I think at least Google had a project that used this function? Perhaps @ChALkeR can perform a search for us?

@cjihrig
Copy link
Contributor

cjihrig commented Aug 7, 2017

Should we take the argument through a deprecation cycle first?

I think so.

@JacksonTian
Copy link
Contributor Author

Thanks for review. I will update the PR with deprecation cycle later.

@mscdex mscdex added the semver-major PRs that contain breaking changes and should be released in the next major version. label Aug 7, 2017
@BridgeAR
Copy link
Member

Ping @JacksonTian

@BridgeAR
Copy link
Member

Ping @JacksonTian do you still want to pursue this?

@JacksonTian
Copy link
Contributor Author

Sorry. I am too busy to do it. Close it first, i will deal with it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module Issues and PRs related to the module subsystem. repl Issues and PRs related to the REPL subsystem. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants