Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: miscellaneous cleanups for node_config #14868

Closed
wants to merge 1 commit into from
Closed

src: miscellaneous cleanups for node_config #14868

wants to merge 1 commit into from

Commits on Aug 17, 2017

  1. src: miscellaneous cleanups for node_config 

    Includes a fix for setting the `icuDataDir` as a UTF8 string
rather than one byte. Previously, if the dir contained any
non-ascii characters they would be mangled. This won't cover
cases that involve paths with other character encodings
(thank you Linux).. but it will cover the most likely.

Other miscellaneous cleanups are included
    @jasnell
    jasnell committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    7a03b9f View commit details
    Browse the repository at this point in the history