build: add npx to zip and 7z packages #15033
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy npx and npx.cmd from `deps\npm\bin` for consistency with .msi package. Refs: nodejs#14235
nodejs-github-bot
added
build
|
.msi was modified, but the zip and 7z packages were overlooked in #14235 |
gibfahn
approved these changes
Aug 25, 2017
|
It feels like there should be a test for this, but AFAIK we don't have package level tests. |
jasnell
approved these changes
Aug 25, 2017
|
cc/ @nodejs/platform-windows |
|
Oops! Thanks for picking this up. 👍 |
|
Landed in b46d596 |
richardlau
added
dont-land-on-v4.x
npm
ghost
pushed a commit
to ayojs/ayo
that referenced
this pull request
Aug 30, 2017
Copy npx and npx.cmd from `deps\npm\bin` for consistency with .msi package. PR-URL: nodejs/node#15033 Refs: nodejs/node#14235 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
ghost
pushed a commit
to ayojs/ayo
that referenced
this pull request
Aug 30, 2017
Copy npx and npx.cmd from `deps\npm\bin` for consistency with .msi package. PR-URL: nodejs/node#15033 Refs: nodejs/node#14235 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Aug 31, 2017
Copy npx and npx.cmd from `deps\npm\bin` for consistency with .msi package. PR-URL: nodejs#15033 Refs: nodejs#14235 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy npx and npx.cmd from
deps\npm\binfor consistency with .msipackage.
Refs: #14235
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build