From 0ac09ae0fecef5400e58cee0241834202996b5af Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Szczepa=C5=84ski?= Date: Wed, 30 Aug 2017 23:46:26 +0200 Subject: [PATCH] src: remove not relevant todo from node_crypto.cc TODO comment from node_crypto is no longer relevant. Unification of commented code and string_bytes code would bloat the latter. Methods for hex encoding produce different output in both files (crypto adds colon and uses uppercase letters.) Common path between those two is very limited now. --- src/node_crypto.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/src/node_crypto.cc b/src/node_crypto.cc index 1fa522d521acec..6a25b9181c9ac9 100644 --- a/src/node_crypto.cc +++ b/src/node_crypto.cc @@ -1627,7 +1627,6 @@ static Local X509ToObject(Environment* env, X509* cert) { const char hex[] = "0123456789ABCDEF"; char fingerprint[EVP_MAX_MD_SIZE * 3]; - // TODO(indutny): Unify it with buffer's code for (i = 0; i < md_size; i++) { fingerprint[3*i] = hex[(md[i] & 0xf0) >> 4]; fingerprint[(3*i)+1] = hex[(md[i] & 0x0f)];