From 340ad76603cba460f839d678114d5452cbf30769 Mon Sep 17 00:00:00 2001 From: James M Snell Date: Wed, 6 Sep 2017 15:47:58 -0700 Subject: [PATCH 1/2] meta: allow vague objections to be dismissed Explicitly allow vague objections to change requests to be dismissed if requests for clarification go unanswered --- COLLABORATOR_GUIDE.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 5aa0fb49cd68a6..bc20923decfacd 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -88,6 +88,11 @@ All pull requests that modify executable code should be subjected to continuous integration tests on the [project CI server](https://ci.nodejs.org/). +If any Collaborator objects to a change without giving any additional +explanation or context, and the objecting Collaborator fails to respond to +explicit requests for explanation or context within a reasonable period of +time, the objection may be dismissed. + #### Useful CI Jobs * [`node-test-pull-request`](https://ci.nodejs.org/job/node-test-pull-request/) From 5c13b172b7a752663f4f5af0bd87d29a9acc4101 Mon Sep 17 00:00:00 2001 From: James M Snell Date: Wed, 6 Sep 2017 23:55:02 -0700 Subject: [PATCH 2/2] [Squash] Nits --- COLLABORATOR_GUIDE.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index bc20923decfacd..2a559af5bd57b4 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -88,10 +88,11 @@ All pull requests that modify executable code should be subjected to continuous integration tests on the [project CI server](https://ci.nodejs.org/). -If any Collaborator objects to a change without giving any additional -explanation or context, and the objecting Collaborator fails to respond to +If any Collaborator objects to a change *without giving any additional +explanation or context*, and the objecting Collaborator fails to respond to explicit requests for explanation or context within a reasonable period of -time, the objection may be dismissed. +time, the objection may be dismissed. Note that this does not apply to +objections that are explained. #### Useful CI Jobs