test: http2 ERR_INVALID_ARG_TYPE tests #15766
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Oct 4, 2017
danbev
approved these changes
Oct 4, 2017
lpinca
reviewed
Oct 5, 2017
| // Error if options are not passed to createSecureServer | ||
| invalidOptions.forEach((invalidOption) => | ||
| common.expectsError( | ||
| () => http2.createSecureServer(() => invalidOption), |
There was a problem hiding this comment.
The first argument of http2.createSecureServer() should be invalidOption or we only check that a function is not a valid argument.
There was a problem hiding this comment.
Thanks for the catch @lpinca
I've corrected it.
trivikr
force-pushed
the
test-http2-invalid-arg-type
branch
from
50afc20
to
d06ea66
Compare
lpinca
approved these changes
Oct 5, 2017
trivikr
force-pushed
the
test-http2-invalid-arg-type
branch
from
d06ea66
to
7a82fbc
Compare
|
rebased with upstream/master |
cjihrig
approved these changes
Oct 16, 2017
|
Landed in 0ce6be0 |
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 18, 2017
PR-URL: nodejs/node#15766 Ref: nodejs/node#14985 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests for testing ERR_INVALID_ARG_TYPE errors in priority() and rstStream()
Refs: #14985
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, http2