From c46913e4499fdfef3aff96ee886126d458e0746e Mon Sep 17 00:00:00 2001 From: agilbert Date: Fri, 6 Oct 2017 09:31:59 -0700 Subject: [PATCH 1/2] test: clean up string concat in dlopen-ping-pong replace string concatenation with template literals. --- test/addons/dlopen-ping-pong/test.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/addons/dlopen-ping-pong/test.js b/test/addons/dlopen-ping-pong/test.js index 9f07715cf15680..ad554d569d09b3 100644 --- a/test/addons/dlopen-ping-pong/test.js +++ b/test/addons/dlopen-ping-pong/test.js @@ -11,7 +11,8 @@ const os = require('os'); const bindingPath = require.resolve(`./build/${common.buildType}/binding`); process.dlopen(module, bindingPath, os.constants.dlopen.RTLD_NOW | os.constants.dlopen.RTLD_GLOBAL); -module.exports.load(path.dirname(bindingPath) + '/ping.so'); +module.exports.load(`${path.dirname(bindingPath)}/ping.so`); + assert.strictEqual(module.exports.ping(), 'pong'); // Check that after the addon is loaded with From 105de8ec9032f52a25e41f67790b352cf768e410 Mon Sep 17 00:00:00 2001 From: agilbert Date: Fri, 6 Oct 2017 09:41:42 -0700 Subject: [PATCH 2/2] test: remove extra whitespace --- test/addons/dlopen-ping-pong/test.js | 1 - 1 file changed, 1 deletion(-) diff --git a/test/addons/dlopen-ping-pong/test.js b/test/addons/dlopen-ping-pong/test.js index ad554d569d09b3..c533593496090a 100644 --- a/test/addons/dlopen-ping-pong/test.js +++ b/test/addons/dlopen-ping-pong/test.js @@ -12,7 +12,6 @@ const bindingPath = require.resolve(`./build/${common.buildType}/binding`); process.dlopen(module, bindingPath, os.constants.dlopen.RTLD_NOW | os.constants.dlopen.RTLD_GLOBAL); module.exports.load(`${path.dirname(bindingPath)}/ping.so`); - assert.strictEqual(module.exports.ping(), 'pong'); // Check that after the addon is loaded with