Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove process._debugPause() #17060

Merged
merged 1 commit into from
Nov 20, 2017

Conversation

bnoordhuis
Copy link
Member

@bnoordhuis bnoordhuis commented Nov 15, 2017

This method is undocumented and depends on a V8 API that is slated for
removal. The inspector and node-inspect don't use it and I could find
no third-party code that depends on it. Remove it.

CI: https://ci.nodejs.org/job/node-test-pull-request/11463/

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 15, 2017
@bnoordhuis bnoordhuis added the semver-major PRs that contain breaking changes and should be released in the next major version. label Nov 15, 2017
This method is undocumented and depends on a V8 API that is slated for
removal.  The inspector and node-inspect don't use it and I could find
no third-party code that depends on it.  Remove it.

PR-URL: nodejs#17060
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
@bnoordhuis bnoordhuis force-pushed the rm-process-debug-pause branch from 7f2bef7 to 804eb3c Compare November 20, 2017 22:46
@bnoordhuis bnoordhuis closed this Nov 20, 2017
@bnoordhuis bnoordhuis deleted the rm-process-debug-pause branch November 20, 2017 22:46
@bnoordhuis bnoordhuis merged commit 804eb3c into nodejs:master Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants