-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: patch V8 to 6.2.414.46 #17206
Closed
Closed
deps: patch V8 to 6.2.414.46 #17206
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,7 +20,7 @@ For more discussion of MB, see also [the design spec](design_spec.md). | |
|
||
### `mb analyze` | ||
|
||
`mb analyze` is responsible for determining what targets are affected by | ||
`mb analyze` is reponsible for determining what targets are affected by | ||
a list of files (e.g., the list of files in a patch on a trybot): | ||
|
||
``` | ||
|
@@ -45,12 +45,12 @@ a single object with the following fields: | |
reflect the stuff we might want to build *in addition to* the list | ||
passed in `test_targets`. Targets in this list will be treated | ||
specially, in the following way: if a given target is a "meta" | ||
(GN: group, GYP: none) target like 'blink_tests' or | ||
'chromium_builder_tests', or even the ninja-specific 'all' target, | ||
then only the *dependencies* of the target that are affected by | ||
the modified files will be rebuilt (not the target itself, which | ||
might also cause unaffected dependencies to be rebuilt). An empty | ||
list will be treated as if there are no additional targets to build. | ||
(GN: group, GYP: none) target like 'blink_tests' or or even the | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Typo: |
||
ninja-specific 'all' target, then only the *dependencies* of the | ||
target that are affected by the modified files will be rebuilt | ||
(not the target itself, which might also cause unaffected dependencies | ||
to be rebuilt). An empty list will be treated as if there are no additional | ||
targets to build. | ||
Empty lists for both `test_targets` and `additional_compile_targets` | ||
would cause no work to be done, so will result in an error. | ||
* `targets`: a legacy field that resembled a union of `compile_targets` | ||
|
@@ -167,6 +167,21 @@ The `-f/--config-file` and `-q/--quiet` flags work as documented for | |
This is mostly useful as a presubmit check and for verifying changes to | ||
the config file. | ||
|
||
### `mb gerrit-buildbucket-config` | ||
|
||
Generates a gerrit buildbucket configuration file and prints it to | ||
stdout. This file contains the list of trybots shown in gerrit's UI. | ||
|
||
The master copy of the buildbucket.config file lives | ||
in a separate branch of the chromium repository. Run `mb | ||
gerrit-buildbucket-config > buildbucket.config.new && git fetch origin | ||
refs/meta/config:refs/remotes/origin/meta/config && git checkout | ||
-t -b meta_config origin/meta/config && mv buildbucket.config.new | ||
buildbucket.config` to update the file. | ||
|
||
Note that after committing, `git cl upload` will not work. Instead, use `git | ||
push origin HEAD:refs/for/refs/meta/config` to upload the CL for review. | ||
|
||
## Isolates and Swarming | ||
|
||
`mb gen` is also responsible for generating the `.isolate` and | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which repo this typos should be reported?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the V8 project: https://bugs.chromium.org/p/v8/issues/list