Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make common.mustNotCall show file:linenumber #17257

Closed
wants to merge 8 commits into from
Closed

test: make common.mustNotCall show file:linenumber #17257

wants to merge 8 commits into from

Commits on Dec 4, 2017

  1. test: make common.mustNotCall show file:linenumber 

    When a test fails via `common.mustNotCall` it is sometimes hard to
determine exactly what was called. This modification stores the
caller's file and line number by using the V8 Error API to capture
a stack at the time `common.mustNotCall()` is called. In the event
of failure, this information is printed.
    @lance
    lance committed Dec 4, 2017
    Configuration menu
    Copy the full SHA
    4d3a0b1 View commit details
    Browse the repository at this point in the history

  2. test: add test for common.mustNotCall

    @lance
    lance committed Dec 4, 2017
    Configuration menu
    Copy the full SHA
    c54e1e1 View commit details
    Browse the repository at this point in the history

  3. test: export commmon.getCallSite

    @lance
    lance committed Dec 4, 2017
    Configuration menu
    Copy the full SHA
    b9402b7 View commit details
    Browse the repository at this point in the history

  4. test: change common.getCallSite to take a function 

    Instead of indexing into the call stack to find the right level
to store, just use the `Error.captureStackTrace()` function's
second parameter - a function pointer.
    @lance
    lance committed Dec 4, 2017
    Configuration menu
    Copy the full SHA
    9e0363d View commit details
    Browse the repository at this point in the history

  5. test: fix comment formatting

    @lance
    lance committed Dec 4, 2017
    Configuration menu
    Copy the full SHA
    451ea32 View commit details
    Browse the repository at this point in the history

  6. test: document common.getCallSite()

    @lance
    lance committed Dec 4, 2017
    Configuration menu
    Copy the full SHA
    ae47bce View commit details
    Browse the repository at this point in the history

  7. test: add check for win32 and modify message 

    Because of the way this test splits up the message string on ':'
we need to ensure that the initial drive letter does not affect
the string manipulation. Shortening it by 2 characters solves this.
    @lance
    lance committed Dec 4, 2017
    Configuration menu
    Copy the full SHA
    9e23ec2 View commit details
    Browse the repository at this point in the history

  8. test: fix typo in common.getCallSite doc

    @lance
    lance committed Dec 4, 2017
    Configuration menu
    Copy the full SHA
    8e7589c View commit details
    Browse the repository at this point in the history