Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test:parameters of fs read and readsync #17910

Closed
wants to merge 4 commits into from
Closed

test:parameters of fs read and readsync #17910

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ee7e0c6
test:parameters of fs read and readsync
bacriom Dec 29, 2017
7af2784
test:parameters of fs read and readsync
bacriom Dec 29, 2017
14e1660
test:parameters of fs read and readsync
bacriom Dec 29, 2017
f4e9a87
update fs read tests cases
bacriom Jan 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 63 additions & 0 deletions test/parallel/test-fs-read-type.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ const filepath = fixtures.path('x.txt');
const fd = fs.openSync(filepath, 'r');
const expected = 'xyz\n';


// Error must be thrown with string
common.expectsError(
() => fs.read(fd, expected.length, 0, 'utf-8', common.mustNotCall()),
Expand All @@ -17,6 +18,39 @@ common.expectsError(
}
);

[true, null, undefined, () => {}, {}].forEach((value) => {
common.expectsError(() => {
fs.read(value,
Buffer.allocUnsafe(expected.length),
0,
expected.length,
0,
common.mustNotCall());
}, { code: 'ERR_INVALID_ARG_TYPE', type: TypeError,
message: 'The "fd" argument must be of type integer' });
});

common.expectsError(() => {
fs.read(fd,
Buffer.allocUnsafe(expected.length),
-1,
expected.length,
0,
common.mustNotCall());
}, { code: 'ERR_OUT_OF_RANGE', type: RangeError,
message: 'The value of "offset" is out of range.' });

common.expectsError(() => {
fs.read(fd,
Buffer.allocUnsafe(expected.length),
0,
-1,
0,
common.mustNotCall());
}, { code: 'ERR_OUT_OF_RANGE', type: RangeError,
message: 'The value of "length" is out of range.' });


common.expectsError(
() => fs.readSync(fd, expected.length, 0, 'utf-8'),
{
Expand All @@ -25,3 +59,32 @@ common.expectsError(
message: 'The "buffer" argument must be one of type Buffer or Uint8Array'
}
);

[true, null, undefined, () => {}, {}].forEach((value) => {
common.expectsError(() => {
fs.readSync(value,
Buffer.allocUnsafe(expected.length),
0,
expected.length,
0);
}, { code: 'ERR_INVALID_ARG_TYPE', type: TypeError,
message: 'The "fd" argument must be of type integer' });
});

common.expectsError(() => {
fs.readSync(fd,
Buffer.allocUnsafe(expected.length),
-1,
expected.length,
0);
}, { code: 'ERR_OUT_OF_RANGE', type: RangeError,
message: 'The value of "offset" is out of range.' });

common.expectsError(() => {
fs.readSync(fd,
Buffer.allocUnsafe(expected.length),
0,
-1,
0);
}, { code: 'ERR_OUT_OF_RANGE', type: RangeError,
message: 'The value of "length" is out of range.' });