Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Node Slack community to support options #18191

Closed
wants to merge 2 commits into from
Closed

Add Node Slack community to support options #18191

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f8b8a0
doc: add Slack community to support options
hackygolucky Jan 16, 2018
98b1602
fixup: address comment
BridgeAR Apr 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ search these unofficial resources:
* [Questions tagged 'node.js' on StackOverflow][]
* [#node.js channel on chat.freenode.net][]. See <http://nodeirc.info/> for more
information.
* [Node.js Slack Community](http://node-js.slack.com): Visit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Micro-nit: There should be a trailing slash on the URL in this line.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, much less of a nit and more important: This should be https. (Yes, it redirects. But still, that first request can send cookies unencrypted and have MITM content inserted and all that stuff.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed.

[nodeslackers.com](http://www.nodeslackers.com/) to register.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish this URL was https. Looks like it's not served over HTTPS unfortunately. Leaving this comment here in case whoever runs it sees this and there's anything that can be done about it. Non-blocking on landing this.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬 woops, yeah i'll get on that first thing tomorrow and let you know


GitHub issues are meant for tracking enhancements and bugs, not general support.

Expand Down