test: check error type in net.Server.listen() callback and avoid setTimeout() in test #1821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }); | ||
|
|
||
|
|
||
| server1.listen(common.PORT, function() { | ||
| console.error('server1 listening'); | ||
| server1listening = true; | ||
|
|
There was a problem hiding this comment.
could you please remove this whitespace change?
|
Besides the little whitespace nitpicks, this LGTM. Thanks for the PR 😄 it reduces runtime of this test by about a tenth of a second, too. |
|
Not a review but can you reword the commit log so it conforms to the guidelines from CONTRIBUTING.md? |
This change eliminates an unnecessary setTimeout() in the test.
|
Pushed a new version of the commit that fixes the whitespace goofs identified by @brendanashworth and has a conforming commit message as pointed out by @bnoordhuis |
bnoordhuis
pushed a commit
that referenced
this pull request
May 30, 2015
This change eliminates an unnecessary setTimeout() in the test. PR-URL: #1821 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
|
Thanks Rich, landed in 8059393. |
andrewdeandrade
pushed a commit
to andrewdeandrade/node
that referenced
this pull request
Jun 3, 2015
This change eliminates an unnecessary setTimeout() in the test. PR-URL: nodejs/node#1821 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a task from a
TODOcomment.ref: #264