util: introduce `util.types.is[…]` type checks #18415

addaleax · 2018-01-27T23:01:35Z

Provide public APIs for native typechecking that is actually useful. The motivation for this is providing alternatives to userland modules that would currently rely on process.binding('util').

This is based off the list in v8.h, with things that have better JS equivalents removed; I’m happy to bikeshed this list.

Also, for context, previous efforts:

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

util

evanlucas

LGTM with a few nits. Are we sure we want to put this on util as opposed to a new module?

I would lean more towards a types module, but am fine either way. Thanks for doing this!!

evanlucas · 2018-01-28T00:10:02Z

doc/api/util.md

+For example:
+
+```js
+util.types.isAsyncFunction(function foo() {});  // Returns false


should this be isGeneratorFunction

evanlucas · 2018-01-28T00:10:21Z

doc/api/util.md

+For example:
+
+```js
+util.types.isPromise(new Map());  // Returns true


ChALkeR · 2018-01-28T00:24:59Z

@evanlucas Introducing a new module is a semver-major, as it would break npmjs.com/types module.

ChALkeR · 2018-01-28T00:33:22Z

lib/internal/bootstrap_node.js

+                    'Accessing native typechecking bindings of Node ' +
+                    'directly is deprecated. ' +
+                    `Please use \`util.types.${name}\` instead.`,
+                    'DEP0XXX') :


If a new deprecation is introduced, it should be recorded in doc/api/deprecations.md.

TimothyGu · 2018-01-28T00:53:58Z

src/node_types.cc

+  V(WeakMap)                                                                  \
+  V(WeakSet)                                                                  \
+  V(ArrayBuffer)                                                              \
+  V(TypedArray)                                                               \


We no longer need this with isTypedArray being present in lib/internal/types.js.

TimothyGu · 2018-01-28T00:54:55Z

src/node_types.cc

+namespace {
+
+#define VALUE_METHOD_MAP(V)                                                   \
+  V(External)                                                                 \


Four-space indentation. Ditto elsewhere.

@TimothyGu All other macro lists I can find use 2 spaces for indentation?

Heh. Never mind then, I guess.

addaleax · 2018-01-28T01:55:05Z

@evanlucas Like @ChALkeR said, I couldn’t find a suitable name, that’s all. I don’t think util is a terrible home for this, though.

@evanlucas @ChALkeR @TimothyGu Addressed your nits :)

vsemozhetbyt · 2018-01-28T02:10:37Z

doc/api/util.md

@@ -943,11 +1450,11 @@ added: v0.6.0
 deprecated: v4.0.0
 -->

-> Stability: 0 - Deprecated
+> Stability: 0 - Deprecated: Use [`Array.isArray`][] instead.


Maybe Array.isArray() as per our style guide note about parentheses after methods (+ below and in the bottom reference).

@vsemozhetbyt Yup, done!

vsemozhetbyt · 2018-01-28T02:14:27Z

doc/api/util.md

@@ -1014,7 +1521,7 @@ added: v0.6.0
 deprecated: v4.0.0
 -->

-> Stability: 0 - Deprecated
+> Stability: 0 - Deprecated: Use [`util.types.isDate()`][] instead.


util.types.isDate() seems undocumented.

@vsemozhetbyt Oops, thanks for catching this!

vsemozhetbyt · 2018-01-28T02:26:17Z

doc/api/util.md

@@ -1176,7 +1697,8 @@ added: v0.11.5
 deprecated: v4.0.0
 -->

-> Stability: 0 - Deprecated
+> Stability: 0 - Deprecated: Use
+> `typeof value === 'object' && typeof value !== 'function' ` instead.


&& value !== null?

+ Is not typeof value can be either'object' or 'function'?

> const v = ()=>{} undefined > typeof v === 'object' false > typeof v 'function'

vsemozhetbyt · 2018-01-28T02:38:45Z

doc/api/util.md

@@ -1202,7 +1724,8 @@ added: v0.11.5
 deprecated: v4.0.0
 -->

-> Stability: 0 - Deprecated
+> Stability: 0 - Deprecated:
+> Use `typeof value !== 'object' && typeof value !== 'function'` instead.


|| value === null ?

TimothyGu · 2018-01-28T02:17:21Z

doc/api/util.md

+For example:
+
+```js
+util.types.isNativeError(new Error());  // Returns true


Would be good to have TypeError (and/or some other built-in Errors) here too.

TimothyGu · 2018-01-28T02:19:21Z

doc/api/util.md

+For example:
+
+```js
+util.types.isMapIterator((new Map())[Symbol.iterator]());  // Returns true


Something that may be surprising to JavaScript developers unfamiliar with iterators is that the iterators returned from .keys(), .values(), .entries(), and [@@iterator]() in fact look the same from the outside. Maybe have them here as well would aid comprehension? (Ditto for Set.)

TimothyGu · 2018-01-28T02:20:52Z

doc/api/util.md

+util.types.isUint8ClampedArray(new Float64Array());  // Returns false
+```
+
+### util.types.isUint16Array(value)


Alphabetically (what other API docs do), Uint16 would sort earlier than Uint8. This is certainly as good of a place for exception as any, but I'd like to keep it consistent for now.

The same for util.types.isInt8Array(value).

I do think this sorting order is a little less weird, tbh … 😄

TimothyGu · 2018-01-28T02:23:39Z

doc/api/util.md

+
+```js
+async function checkModule(wasmBuffer) {
+  const { module } = await WebAssembly.compile(wasmBuffer);


Would new WebAssembly.Module(wasmBuffer) be a better example because of its synchronicity?

If this asynchronous example is to be kept, then it seems ^{MDN spec} it should be const module = rather than const { module } =.

If this asynchronous example is to be kept, then it seems ^{MDN spec} it should be const module = rather than const { module } =.

I don’t know why, but I don’t think V8 and MDN agree here.

Seems like you used compile here but instantiate in the test. Instantiate does indeed return { module, instance }.

TimothyGu · 2018-01-28T02:26:59Z

doc/api/util.md

@@ -1176,7 +1697,8 @@ added: v0.11.5
 deprecated: v4.0.0
 -->

-> Stability: 0 - Deprecated
+> Stability: 0 - Deprecated: Use
+> `typeof value === 'object' && typeof value !== 'function' ` instead.


This function is implemented as value !== null && typeof value === 'object'.

Maybe also mention that even though functions are also objects, isObject historically returned false even for functions, because it's broken.

The doc as-is doesn't make much sense.

TimothyGu · 2018-01-28T02:34:36Z

doc/api/util.md

+added: REPLACEME
+-->
+
+Returns `true` if the value is a string object, e.g. created


s/string/symbol/

Also, no need for e.g. as Object() is the only way to get symbol objects in JavaScript (new Symbol() always throws an error).

TimothyGu · 2018-01-28T02:37:49Z

test/parallel/test-util-types.js

+
+(async function() {
+  const buffer = fixtures.readSync('test.wasm');
+  const { module } = await WebAssembly.instantiate(buffer, {});


Ditto as the documentation change. You could use WebAssembly.Module's constructor to avoid the async-ness. If not, we don't really need to instantiate it. WebAssembly.compile should be sufficient.

Yeah, I simply didn’t know you could just, you know, use new to construct a Module. ;)

TimothyGu · 2018-01-28T02:41:03Z

test/parallel/test-util-types.js

+const exclude = [
+  'Undefined', 'Null', 'NullOrUndefined', 'True', 'False', 'Name', 'String',
+  'Symbol', 'Function', 'Array', 'Object', 'Boolean', 'Number', 'Int32',
+  'Uint32', 'GeneratorObject'


Do we have an existing check for Generator objects? In any case, I am interested in seeing a reliable JS equivalent for isGeneratorObject.

@TimothyGu I’d guess you’d usually just check for presence of the methods? It’s not “reliable” in the sense that the V8 method is, but I didn’t see much benefit in including this, plus (and I could be completely wrong about that) I’d guess that this doesn’t work on transpiled generator functions anyway?

I’m happy to include it if you think it makes sense.

I’d guess you’d usually just check for presence of the methods?

Doesn't this kind of defeats the whole point of having these functions available?

I’d guess that this doesn’t work on transpiled generator functions anyway?

True, but this wouldn't be the first function that doesn't either.

TimothyGu · 2018-01-28T02:42:16Z

test/parallel/test-util-types.js

+    continue;
+  assert(`is${match[1]}` in types,
+         `util.types should provide check for Is${match[1]}`);
+}


I really like this test!

TimothyGu · 2018-01-28T02:43:01Z

test/parallel/test-util-types.js

+];
+
+if (v8_h === undefined) {
+  process.on('exit', () => common.skip('Could not read v8.h'));


process.on('exit') wouldn't be necessary if the WebAssembly.Module is created synchronously.

vsemozhetbyt · 2018-01-28T02:52:16Z

doc/api/util.md

+[`util.types.isDate()`]: #util_util_types_isdate_value
+[`util.types.isNativeError()`]: #util_util_types_isnativeerror_value
+[`util.types.isSharedArrayBuffer()`]: #util_util_types_issharedarraybuffer_value
+[`TypedArray`]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray


Out of ABC-order?

ChALkeR · 2018-01-28T10:13:22Z

doc/api/deprecations.md

+<a id="DEP0XXX"></a>
+### DEP0XXX: process.binding('util').is[...] typechecks
+
+Type: Documentation-only/`--pending-deprecation`


Is --pending-deprecation the correct type here? It's the first such one, afaik.
DEP0005 is also a --pending-deprecation, but does not mention that explicitly.
/cc @jasnell, I suppose.

Also, --pending-deprecation (and it being a semver-minor) is not mentioned in COLLABORATOR_GUIDE.md#deprecations, but that's probably a separate issue.

As I understand, currently --pending-deprecation is just a subclass of doc-only deprecations.

I opened #18417 for that.

As I understand, currently --pending-deprecation is just a subclass of doc-only deprecations.

I’m okay with seeing it that way, yeah. And I don’t mind being explicit about this here.

#18433 landed, so could you change this line to

Type: Documentation-only (supports [`--pending-deprecation`][])

for consistency?

joyeecheung

LGTM with the wasm example/test changed to sync version

joyeecheung · 2018-01-28T10:43:59Z

doc/api/util.md

+For example:
+
+```js
+util.types.isDataView(new Date());  // Returns true


This should be util.types.isDate(new Date())

vsemozhetbyt · 2018-01-28T13:05:56Z

doc/api/util.md

+added: REPLACEME
+-->
+
+Returns `true` if the value is a async function.


a async ->an async?

vsemozhetbyt · 2018-01-28T13:12:00Z

doc/api/util.md

+util.types.isDataView(new Float64Array());  // Returns false
+```
+
+See also [`ArrayBuffer.isView`][].


ArrayBuffer.isView -> ArrayBuffer.isView() (+ everywhere including bottom reference)?

vsemozhetbyt · 2018-01-28T14:05:37Z

doc/api/util.md

+
+```js
+const target = {};
+const proxy = new Proxy({}, {});


Maybe const proxy = new Proxy(target, {}); to make target more target?)

vsemozhetbyt · 2018-01-28T14:47:34Z

doc/api/util.md

+util.types.isUint8ClampedArray(new Float64Array());  // Returns false
+```
+
+### util.types.isUint16Array(value)


The same for util.types.isInt8Array(value).

vsemozhetbyt · 2018-01-28T14:51:01Z

doc/api/util.md

+[`Uint8ClampedArray`]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Uint8ClampedArray
+[`Uint16Array`]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Uint16Array
+[`Uint32Array`]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Uint32Array
+[`WeakSet`]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WeakSet


Should be after WeakMap.

vsemozhetbyt · 2018-01-28T18:28:46Z

Maybe it is due to big diff, but some old review comments are not hidden now and are associated with the wrong lines, so do not be confused:

#18415 (comment) (or https://github.com/nodejs/node/pull/18415/files#r164285093)

#18415 (comment) (or https://github.com/nodejs/node/pull/18415/files#r164287166)

jasnell · 2018-01-31T19:51:13Z

doc/api/util.md

@@ -894,6 +894,534 @@ encoded bytes.

 The encoding supported by the `TextEncoder` instance. Always set to `'utf-8'`.

+## util.types


Just noting that this will have a named-import-in-ESM issue just like the fs.promises addition.

jasnell · 2018-01-31T19:53:09Z

lib/internal/util/types.js

@@ -29,8 +29,48 @@ function isUint8Array(value) {
  return TypedArrayProto_toStringTag(value) === 'Uint8Array';
 }

+function isUint8ClampedArray(value) {
+  return TypedArrayProto_toStringTag(value) === 'Uint8ClampedArray';


We should likely note in the documentation how these checks are performed because types can lie about what they are if the user overrides Symbol.toStringTag.

This function is cached at Node.js startup and thus immune to userland overrides.

Ah right right... completely zoned on the caching. Just verified locally that even preload script can't lie about this. Dismiss this comment then :-)

Actually... @addaleax ... this would be something worth adding to the tests... specifically, ensuring that a user-provided class overriding a built-in set within a preload module cannot lie and that the checks will come up as false.

a user-provided class overriding a built-in set within a preload module cannot lie

I’m not sure what you mean by that. I have added a test that checks that overriding Symbol.toStringTag doesn’t fool this.

jasnell · 2018-01-31T19:55:45Z

test/parallel/test-util-types.js

+    if ((types.isArrayBufferView(value) ||
+         types.isAnyArrayBuffer(value)) && key.includes('Array')) {
+      continue;
+    }


The test should also likely verify that the result is consistent across vm contexts... e.g. check that vm.runInNewContext('new Map()') passes the type check.

jasnell · 2018-01-31T19:56:48Z

doc/api/util.md

+util.types.isBooleanObject(false);  // Returns false
+util.types.isBooleanObject(true);   // Returns false
+util.types.isBooleanObject(new Boolean(false));   // Returns true
+util.types.isBooleanObject(new Boolean(true));    // Returns true


add:

util.types.isBooleanObject(Boolean(false)); // Returns false util.types.isBooleanObject(Boolean(true)); // Returns false

jasnell · 2018-01-31T19:58:02Z

doc/api/util.md

+added: REPLACEME
+-->
+
+Returns `true` if the value is a built-in [`DataView`][] instance.


Not sure if we should assert that it is 'built-in' in these. The objects can lie, and user code can create their own objects (polyfills) that are not actually built-ins.

jasnell · 2018-01-31T19:59:15Z

doc/api/util.md

+added: REPLACEME
+-->
+
+Returns `true` if the value is an async function.


async function here could be a link to more documentation about async functions... perhaps a link over the MDN documentation?

jasnell · 2018-01-31T20:01:07Z

doc/api/util.md

+
+The result generally does not make any guarantees about what kinds of
+properties or behavior a value exposes in JavaScript. They are primarily
+useful for addon developers who prefer to do type checking in JavaScript.


hmm... this last sentence is a bit content free. why would developers prefer to do type checking in JavaScript :-) ... I think it's better to say something about specific use cases such as "These are primarily useful for debugging" or something similar

@jasnell I can’t really agree … the “why” is, it’s a preference. I personally don’t think it’s a good idea, but it’s what Node decided to migrate to?

Saying “these are primarily useful for debugging” doesn’t really seem more helpful, because it doesn’t even say how you’d use these methods for debugging…

TimothyGu · 2018-01-31T23:59:59Z

test/parallel/test-util-types.js

@@ -0,0 +1,99 @@
+/*global SharedArrayBuffer*/
+'use strict';


There's already https://github.com/nodejs/node/blob/master/test/parallel/test-types.js. You might want to look into combining these two files.

@TimothyGu I’ve just copied the contents into a block in this file, let me know if that doesn’t sound good to you. The tests have somewhat different structures, but I think that’s fine?

PR-URL: #18415 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

Provide public APIs for native typechecking that is actually useful. The motivation for this is providing alternatives to userland modules that would currently rely on `process.binding('util')`. PR-URL: #18415 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

Refs: nodejs#18415

Refs: #18415 PR-URL: #19149 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins · 2018-03-06T21:43:13Z

Should this be backported to v9.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

MylesBorins · 2018-03-06T21:43:59Z

this would need to come with #19149

- Use require('util').types instead of using process.binding('util') to get the type checking helpers - Rename nodeUtil to nodeTypes since that is what it is for Refs: nodejs/node#18415

The old variants have been deprecated since b20af80. Refs: nodejs#18415

The old variants have been deprecated since b20af80. Refs: #18415 PR-URL: #19602 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#18415 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

Provide public APIs for native typechecking that is actually useful. The motivation for this is providing alternatives to userland modules that would currently rely on `process.binding('util')`. PR-URL: nodejs#18415 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

Refs: nodejs#18415 PR-URL: nodejs#19149 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

The old variants have been deprecated since b20af80. Refs: nodejs#18415 PR-URL: nodejs#19602 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#18415 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

Provide public APIs for native typechecking that is actually useful. The motivation for this is providing alternatives to userland modules that would currently rely on `process.binding('util')`. PR-URL: nodejs#18415 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

Refs: nodejs#18415 PR-URL: nodejs#19149 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins · 2018-08-07T19:03:57Z

Is this something we would want to backport to v8.x? Seems like a bunch of moving parts

addaleax added util Issues and PRs related to the built-in util module. semver-minor PRs that contain new features and should be released in the next minor version. labels Jan 27, 2018

nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Jan 27, 2018

evanlucas approved these changes Jan 28, 2018

View reviewed changes

ChALkeR reviewed Jan 28, 2018

View reviewed changes

TimothyGu reviewed Jan 28, 2018

View reviewed changes

vsemozhetbyt reviewed Jan 28, 2018

View reviewed changes

addaleax force-pushed the types-types-types branch from 56e4b7a to bfd7b26 Compare January 28, 2018 02:13

vsemozhetbyt reviewed Jan 28, 2018

View reviewed changes

TimothyGu reviewed Jan 28, 2018

View reviewed changes

vsemozhetbyt reviewed Jan 28, 2018

View reviewed changes

ChALkeR reviewed Jan 28, 2018

View reviewed changes

ChALkeR mentioned this pull request Jan 28, 2018

--pending-deprecation process is underdocumented #18417

Closed

joyeecheung approved these changes Jan 28, 2018

View reviewed changes

vsemozhetbyt reviewed Jan 28, 2018

View reviewed changes

addaleax force-pushed the types-types-types branch from f627e60 to 1900cde Compare January 28, 2018 16:56

cjihrig approved these changes Jan 28, 2018

View reviewed changes

jasnell reviewed Jan 31, 2018

View reviewed changes

TimothyGu reviewed Jan 31, 2018

View reviewed changes

addaleax removed the lib / src Issues and PRs related to general changes in the lib or src directory. label Mar 5, 2018

addaleax added a commit to addaleax/node that referenced this pull request Mar 5, 2018

util: assign missed deprecation number

24efe12

Refs: nodejs#18415

addaleax mentioned this pull request Mar 5, 2018

util: assign missed deprecation number #19149

Closed

addaleax added a commit that referenced this pull request Mar 5, 2018

util: assign missed deprecation number

ae31370

Refs: #18415 PR-URL: #19149 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

joyeecheung mentioned this pull request Mar 6, 2018

src: bootstrap internals loaders before bootstrapping Node.js #19112

Closed

2 tasks

MylesBorins added the backport-requested-v9.x label Mar 6, 2018

This was referenced Mar 7, 2018

util: add regression test #19188

Closed

[9.x] src: fix util abort #19223

Closed

[8.x] src: fix util abort #19224

Closed

evanlucas mentioned this pull request Mar 20, 2018

Add 'types' module to core nodejs/node-eps#44

Closed

joyeecheung mentioned this pull request Mar 23, 2018

internal: use util.types to migrate DEP0103 in Node.js lodash/lodash#3704

Merged

addaleax added a commit to addaleax/node that referenced this pull request Mar 26, 2018

zlib,stream: use “official” util.types typechecks

f265275

The old variants have been deprecated since b20af80. Refs: nodejs#18415

addaleax mentioned this pull request Mar 26, 2018

zlib,stream: use “official” util.types typechecks #19602

Closed

2 tasks

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 1, 2018

util: assign missed deprecation number

148210f

Refs: nodejs#18415 PR-URL: nodejs#19149 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

BridgeAR mentioned this pull request May 1, 2018

[9.x] Backport a lot of things #20448

Closed

4 tasks

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018

util: assign missed deprecation number

b179dad

Refs: nodejs#18415 PR-URL: nodejs#19149 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

		@@ -894,6 +894,534 @@ encoded bytes.

		The encoding supported by the `TextEncoder` instance. Always set to `'utf-8'`.

		## util.types

util: introduce util.types.is[…] type checks #18415

util: introduce util.types.is[…] type checks #18415

Conversation

addaleax commented Jan 27, 2018

Checklist

Affected core subsystem(s)

evanlucas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ChALkeR commented Jan 28, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

addaleax commented Jan 28, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vsemozhetbyt Jan 28, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TimothyGu Jan 28, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ChALkeR Jan 28, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ChALkeR Jan 30, 2018 • edited Loading

Choose a reason for hiding this comment

joyeecheung left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vsemozhetbyt commented Jan 28, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MylesBorins commented Mar 6, 2018

MylesBorins commented Mar 6, 2018

MylesBorins commented Aug 7, 2018

util: introduce `util.types.is[…]` type checks #18415

util: introduce `util.types.is[…]` type checks #18415

vsemozhetbyt Jan 28, 2018 •

edited

Loading

TimothyGu Jan 28, 2018 •

edited

Loading

ChALkeR Jan 28, 2018 •

edited

Loading

ChALkeR Jan 30, 2018 •

edited

Loading