Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc,assert,timers: assign deprecation codes #18564

Closed
wants to merge 2 commits into from
Closed

doc,assert,timers: assign deprecation codes #18564

wants to merge 2 commits into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Feb 4, 2018

Overlooked when landing the respective PRs.

/cc @Fishrock123 @BridgeAR @jasnell

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc,assert,timers

@addaleax
doc,assert,timers: assign deprecation codes
6f22ab8 
Overlooked when landing the respective PRs.
@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. labels Feb 4, 2018
@Fishrock123
Copy link
Contributor

Oh hmm, I guess I thought these were done at release time for some reason. Sorry about that.

@Fishrock123
Copy link
Contributor

I think that test case should still be 4 though. Can’t check atm.

@addaleax
Copy link
Member Author

addaleax commented Feb 4, 2018

@Fishrock123 It’s 5 because the real deprecation codes for unenroll and enroll are different, unlike the placeholders, so there’s 2 extra warnings now

ChALkeR
ChALkeR reviewed Feb 4, 2018
View reviewed changes
lib/timers.js Outdated
@@ -377,7 +377,7 @@ function enroll(item, msecs) {
exports.enroll = util.deprecate(enroll,
'timers.unenroll() is deprecated. ' +
Copy link
Member

@ChALkeR ChALkeR Feb 4, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/unenroll/enroll/ ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deprecation code is for enroll below, but the message is about unenroll().

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChALkeR done

@ChALkeR
Copy link
Member

ChALkeR commented Feb 4, 2018 •
edited
Loading

@Fishrock123

I think that test case should still be 4 though. Can’t check atm.

Those were using the same deprecation number DEP00XX, and now use different ones — that probably explains why one less warning is supressed.

Perhaps it would be better to use DEP00XX DEP00XY in further PRs that introduce two separate deprecation warnings (until they land).

ChALkeR
ChALkeR suggested changes Feb 4, 2018
View reviewed changes
Copy link
Member

@ChALkeR ChALkeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment.

@BridgeAR BridgeAR added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Feb 5, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Feb 6, 2018
@addaleax @BridgeAR
doc,assert,timers: assign deprecation codes
82a7347 
Overlooked when landing the respective PRs.

PR-URL: nodejs#18564
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@BridgeAR
Copy link
Member

BridgeAR commented Feb 6, 2018

Landed in 82a7347

As a side note: I updated my script to complain in case something has to be replaced while landing ;-)

@BridgeAR BridgeAR closed this Feb 6, 2018
@MylesBorins
Copy link
Contributor

Should this be backported to v9.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@addaleax @MayaLekova
doc,assert,timers: assign deprecation codes
a25c5a2 
Overlooked when landing the respective PRs.

PR-URL: nodejs#18564
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@MylesBorins
Copy link
Contributor

Should this be backported to v8.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

@addaleax addaleax deleted the missing-deprecation-codes branch August 8, 2018 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@evanlucas evanlucas evanlucas approved these changes

@jasnell jasnell jasnell approved these changes

@ChALkeR ChALkeR ChALkeR approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@addaleax @Fishrock123 @ChALkeR @BridgeAR @MylesBorins @jasnell @evanlucas @lpinca @cjihrig @nodejs-github-bot