Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: allow _httpMessage to be GC'ed #18865

Closed
wants to merge 1 commit into from
Closed

http: allow _httpMessage to be GC'ed #18865

wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Feb 19, 2018

Set socket._httpMessage to null before emitting the 'connect' or 'upgrade' event.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

http

@lpinca
http: allow _httpMessage to be GC'ed
c106d80 
Set `socket._httpMessage` to `null` before emitting the `'connect'` or
`'upgrade'` event.
@nodejs-github-bot nodejs-github-bot added the http Issues or PRs related to the http subsystem. label Feb 19, 2018
@lpinca
Copy link
Member Author

lpinca commented Feb 19, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/13272/

@lpinca lpinca added the semver-major PRs that contain breaking changes and should be released in the next major version. label Feb 19, 2018
@lpinca
Copy link
Member Author

lpinca commented Feb 19, 2018

Tagged as semver-major for extra safety but imho it's a bug fix.

@lpinca lpinca added the memory Issues and PRs related to the memory management or memory footprint. label Feb 19, 2018
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 21, 2018
mcollina
mcollina approved these changes Feb 22, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I’d call it a bugfix too.

@BridgeAR BridgeAR removed the semver-major PRs that contain breaking changes and should be released in the next major version. label Feb 22, 2018
@BridgeAR
Copy link
Member

I agree about being a bug fix as well and removed the label accordingly. If someone does not agree, please add it back in again.

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Feb 22, 2018
@lpinca @BridgeAR
http: allow _httpMessage to be GC'ed
e5369e0 
Set `socket._httpMessage` to `null` before emitting the `'connect'` or
`'upgrade'` event.

PR-URL: nodejs#18865
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@BridgeAR
Copy link
Member

Landed in e5369e0 🎉

@BridgeAR BridgeAR closed this Feb 22, 2018
@lpinca
Copy link
Member Author

lpinca commented Feb 22, 2018

Yes, it would be nice to have this backported.

@lpinca lpinca deleted the null/_httpMessage branch February 22, 2018 14:35
addaleax pushed a commit to addaleax/node that referenced this pull request Feb 26, 2018
@lpinca @addaleax
http: allow _httpMessage to be GC'ed
e3f901c 
Set `socket._httpMessage` to `null` before emitting the `'connect'` or
`'upgrade'` event.

PR-URL: nodejs#18865
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
addaleax pushed a commit that referenced this pull request Feb 26, 2018
@lpinca @addaleax
http: allow _httpMessage to be GC'ed
c7f9608 
Set `socket._httpMessage` to `null` before emitting the `'connect'` or
`'upgrade'` event.

PR-URL: #18865
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@addaleax addaleax mentioned this pull request Feb 27, 2018
Closed
MylesBorins pushed a commit that referenced this pull request Apr 13, 2018
@lpinca @MylesBorins
http: allow _httpMessage to be GC'ed
1edadeb 
Set `socket._httpMessage` to `null` before emitting the `'connect'` or
`'upgrade'` event.

PR-URL: #18865
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 13, 2018
@lpinca @MylesBorins
http: allow _httpMessage to be GC'ed
29c395d 
Set `socket._httpMessage` to `null` before emitting the `'connect'` or
`'upgrade'` event.

PR-URL: #18865
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 13, 2018
Merged
@MylesBorins MylesBorins mentioned this pull request May 2, 2018
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@lpinca @MayaLekova
http: allow _httpMessage to be GC'ed
cd4af7a 
Set `socket._httpMessage` to `null` before emitting the `'connect'` or
`'upgrade'` event.

PR-URL: nodejs#18865
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@jordanrogers jordanrogers mentioned this pull request May 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http Issues or PRs related to the http subsystem. memory Issues and PRs related to the memory management or memory footprint.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lpinca @BridgeAR @mcollina @addaleax @cjihrig @MylesBorins @nodejs-github-bot