Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant the #19008

Closed
wants to merge 1 commit into from
Closed

Remove redundant the #19008

wants to merge 1 commit into from

Conversation

Leko
Copy link
Contributor

@Leko Leko commented Feb 26, 2018

Fix the the → the.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 26, 2018
@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 26, 2018
devsnek
devsnek approved these changes Feb 26, 2018
View reviewed changes
Copy link
Member

@devsnek devsnek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to rg this is the the last instance of this in the codebase (not including 3rd party code) 🎉

jasnell pushed a commit that referenced this pull request Feb 26, 2018
@Leko @jasnell
doc: remove redundant the
e6b823d 
PR-URL: #19008
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@jasnell
Copy link
Member

jasnell commented Feb 26, 2018

Landed in e6b823d

@jasnell jasnell closed this Feb 26, 2018
@Leko Leko deleted the fix-the-the branch February 26, 2018 18:18
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@Leko @MayaLekova
doc: remove redundant the
041bc19 
PR-URL: nodejs#19008
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@devsnek devsnek devsnek approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@evanlucas evanlucas evanlucas approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Leko @jasnell @evanlucas @lpinca @cjihrig @devsnek @vsemozhetbyt @MylesBorins @nodejs-github-bot