Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade npm to 5.7.1 #19302

Closed
wants to merge 1 commit into from
Closed

deps: upgrade npm to 5.7.1 #19302

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Mar 12, 2018

Depends on #19293

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@targos targos added the blocked PRs that are blocked by other issues or PRs. label Mar 12, 2018
@nodejs-github-bot nodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Mar 12, 2018
@cjihrig
Copy link
Contributor

cjihrig commented Mar 12, 2018

How does this relate to #19298? The diffs are pretty different in size.

@MylesBorins
Copy link
Contributor

it's possible that #19298 didn't follow the upgrade guide, in turn didn't whitespace fix?

@targos
Copy link
Member Author

targos commented Mar 12, 2018

Whoops, I missed #19298. Let's close and check there what happened.

@targos targos closed this Mar 12, 2018
@targos targos deleted the npm-5.7.1 branch April 19, 2018 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
blocked PRs that are blocked by other issues or PRs. npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@targos @cjihrig @MylesBorins @nodejs-github-bot