Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

child_process: better spawn error message #19305

Closed
wants to merge 1 commit into from
Closed

child_process: better spawn error message #19305

wants to merge 1 commit into from

Conversation

bzoz
Copy link
Contributor

@bzoz bzoz commented Mar 12, 2018

Throw ERR_INVALID_ARG_VALUE when filename passed to spawn is empty.

Fixes: #19235

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@bzoz
child_process: better spawn error message
ae987cb 
Throw ERR_INVALID_ARG_VALUE when filename passed to spawn is empty.

Fixes: nodejs#19235
@nodejs-github-bot nodejs-github-bot added the child_process Issues and PRs related to the child_process subsystem. label Mar 12, 2018
@bzoz
Copy link
Contributor Author

bzoz commented Mar 12, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/13649/

@MylesBorins
Copy link
Contributor

Would this be semver major?

@bzoz
Copy link
Contributor Author

bzoz commented Mar 13, 2018

I think it would

@lpinca lpinca added the semver-major PRs that contain breaking changes and should be released in the next major version. label Mar 13, 2018
@bzoz
Copy link
Contributor Author

bzoz commented Mar 21, 2018

New CI: https://ci.nodejs.org/job/node-test-pull-request/13807/

@bzoz
Copy link
Contributor Author

bzoz commented Mar 29, 2018

CI failures are unrelated

@bzoz
Copy link
Contributor Author

bzoz commented Mar 29, 2018

Landed in 9bfe55e

@bzoz bzoz closed this Mar 29, 2018
bzoz added a commit that referenced this pull request Mar 29, 2018
@bzoz
child_process: better spawn error message
9bfe55e 
Throw ERR_INVALID_ARG_VALUE when filename passed to spawn is empty.

Fixes: #19235

PR-URL: #19305
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
child_process Issues and PRs related to the child_process subsystem. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

child_process: confusing error message from functions with empty string argument
6 participants
@bzoz @MylesBorins @addaleax @lpinca @cjihrig @nodejs-github-bot