-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http: setEncoding error for incoming socket connections #19344
Commits on Apr 3, 2018
-
http: setEncoding override for incoming packets
added override to socket.setEncoding to not allow encoding changes for incoming HTTP requests added tests to ensure method throws JavaScript error because an HTTP buffer must be in US-ASCII, this function should not be allowed and should throw an Error currently, the process encounters a fatal v8 error and crashes error report detailed in [issue nodejs#18118](nodejs#18118) Fixes: nodejs#18118 Ref: nodejs#18178
Configuration menu - View commit details
-
Copy full SHA for a7e2aab - Browse repository at this point
Copy the full SHA a7e2aabView commit details -
test: added tests for setEncoding error check
added test to ensure setEncoding inside socket connection would throw an error Fixes: nodejs#18118 Ref: nodejs#18178
Configuration menu - View commit details
-
Copy full SHA for 345ff3c - Browse repository at this point
Copy the full SHA 345ff3cView commit details -
docs, errors, http: disallow setEncoding on incoming packets
added ERR_HTTP_INCOMING_SOCKET_ENCODING error and error docs throw ERR_HTTP_INCOMING_SOCKET_ENCODING error when incoming request socket encoding is manipulated error report detailed in nodejs#18118 Fixes: nodejs#18118 Ref: nodejs#18178
Configuration menu - View commit details
-
Copy full SHA for 4643c63 - Browse repository at this point
Copy the full SHA 4643c63View commit details -
docs, errors: note RFC compliance in error message and documentation
added note and link to RFC7230 >A recipient MUST parse an HTTP message as a sequence of octets in an encoding that is a superset of US-ASCII [USASCII]. Ref: https://tools.ietf.org/html/rfc7230#section-3 Ref: nodejs#18118 Ref: nodejs#18178 Ref: nodejs#19344
Configuration menu - View commit details
-
Copy full SHA for f3c429c - Browse repository at this point
Copy the full SHA f3c429cView commit details -
tests, http: fixed call to ERR_HTTP_INCOMING_SOCKET_ENCODING
internal/errors declaration updated to match new scheme PR-URL: nodejs#19344 Ref: https://tools.ietf.org/html/rfc7230#section-3 Ref: nodejs#18118 Ref: nodejs#18178 Ref: nodejs#19344
Configuration menu - View commit details
-
Copy full SHA for 3613e8d - Browse repository at this point
Copy the full SHA 3613e8dView commit details -
docs, http: minor format changes per review request
PR-URL: nodejs#19344 Ref: https://tools.ietf.org/html/rfc7230#section-3 Ref: nodejs#18118 Ref: nodejs#18178 Ref: nodejs#19344
Configuration menu - View commit details
-
Copy full SHA for 190ef7e - Browse repository at this point
Copy the full SHA 190ef7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 06a34eb - Browse repository at this point
Copy the full SHA 06a34ebView commit details
Commits on Apr 19, 2018
-
Configuration menu - View commit details
-
Copy full SHA for cd2c3ce - Browse repository at this point
Copy the full SHA cd2c3ceView commit details
Commits on Aug 27, 2018
-
Configuration menu - View commit details
-
Copy full SHA for a8c605e - Browse repository at this point
Copy the full SHA a8c605eView commit details