doc: fix punctuation issue in async_hooks.md #19364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move period incorrectly placed outside of parenthesis to inside the parenthesis. The parenthetical in this case is a full sentence.
nodejs-github-bot
added
async_hooks
danbev
approved these changes
Mar 15, 2018
hiroppy
approved these changes
Mar 15, 2018
vsemozhetbyt
added
fast-track
vsemozhetbyt
approved these changes
Mar 15, 2018
jasnell
approved these changes
Mar 15, 2018
gibfahn
approved these changes
Mar 15, 2018
cjihrig
approved these changes
Mar 15, 2018
tniessen
approved these changes
Mar 15, 2018
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Mar 15, 2018
Move period incorrectly placed outside of parentheses to inside the parentheses. The parenthetical in this case is a full sentence. PR-URL: nodejs#19364 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
|
Landed in 9a70b27 |
tniessen
removed
the
author ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move period incorrectly placed outside of parentheses to inside the
parentheses. The parenthetical in this case is a full sentence.
Checklist