Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: remove implied support for win 2012 not R2 #19378

Closed
wants to merge 1 commit into from
Closed

build: remove implied support for win 2012 not R2 #19378

wants to merge 1 commit into from

Conversation

BethGriggs
Copy link
Member

Raising this primarily for the discussion of whether to remove the implied support for Win 2012 not R2. The basis for this is that CI does not run on Win 2012 not R2, and some failures have been deemed specific to this platform.

See:

/cc @gibfahn

Checklist

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Mar 15, 2018
fhinkel
fhinkel approved these changes Mar 16, 2018
View reviewed changes
Copy link
Member

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not familiar with our Windows builds, but the documentation should reflect the supported systems.

@gibfahn
Copy link
Member

gibfahn commented Mar 16, 2018

I'd be +1 on this, but it definitely needs review from @nodejs/build and @nodejs/platform-windows .

The question is when/if we should do this. I'd suggest it be a semver-major that we land in 10.x.

I think the CI failures we've seen on Win 2012 (non-R2) are enough to make this worthwhile.

@gibfahn gibfahn added the semver-major PRs that contain breaking changes and should be released in the next major version. label Mar 16, 2018
@gibfahn gibfahn self-assigned this Mar 16, 2018
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 9, 2018
@BridgeAR
Copy link
Member

BridgeAR commented Apr 9, 2018

This does not require a CI run due to obvious change.

@Trott
Copy link
Member

Trott commented Apr 9, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/468/

(That runs the markdown linter on this file, I'm pretty sure.)

@BridgeAR
Copy link
Member

BridgeAR commented Apr 9, 2018

@gibfahn do you think this should land?

@gibfahn
Copy link
Member

gibfahn commented Apr 9, 2018

Would like @joaocgreis to weigh in if possible, otherwise should be good to go.

@Trott
Copy link
Member

Trott commented Apr 9, 2018

Trying Lite CI again: https://ci.nodejs.org/job/node-test-pull-request-lite/471/

@joaocgreis
Copy link
Member

I'm -0 on this. The failing tests should be addressed, but I agree it's not likely to happen soon.

@BridgeAR
Copy link
Member

Hm, I am unsure if this should land now due to the -0 @joaocgreis

@gibfahn
Copy link
Member

gibfahn commented Apr 13, 2018

I think this should land, @joaocgreis was (I think) expressing that this isn't the ideal solution (to which I agree), but that he wouldn't block it as it's the best option we have.

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Apr 16, 2018
@BethGriggs @BridgeAR
build: remove implied support for win 2012 not R2
4a0dff7 
PR-URL: nodejs#19378
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR
Copy link
Member

Landed in 4a0dff7 🎉

@BridgeAR BridgeAR closed this Apr 16, 2018
jasnell pushed a commit that referenced this pull request Apr 16, 2018
@BethGriggs @jasnell
build: remove implied support for win 2012 not R2
010587b 
PR-URL: #19378
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggs BethGriggs deleted the remove-win2012-notr2 branch July 9, 2018 09:32
@Trott Trott mentioned this pull request Oct 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@seishun seishun seishun approved these changes

@jasnell jasnell jasnell approved these changes

@fhinkel fhinkel fhinkel approved these changes

Assignees

@gibfahn gibfahn

Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@BethGriggs @gibfahn @BridgeAR @Trott @joaocgreis @fhinkel @jasnell @seishun @nodejs-github-bot