Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "process: add more version properties to release" (alternative to #19574) #19577

Closed
wants to merge 1 commit into from
Closed

Revert "process: add more version properties to release" (alternative to #19574) #19577

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

This reverts commit 982e3bd. Alternative to #19574 which only partially reverts said commit.

Refs: #19438

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. process Issues and PRs related to the process subsystem. labels Mar 24, 2018
This was referenced Mar 24, 2018
Closed
Closed
@tniessen
Copy link
Member Author

Should this be fast-tracked instead of #19574?

@tniessen tniessen changed the title Revert "process: add more version properties to release" Revert "process: add more version properties to release" (alternative to #19574) Mar 24, 2018
@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 24, 2018
@tniessen tniessen mentioned this pull request Mar 25, 2018
Closed
2 tasks
@tniessen
Copy link
Member Author

tniessen commented Mar 25, 2018 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-commit-lite/475/

@tniessen
Copy link
Member Author

Reverted in eeb1b9d.

@tniessen tniessen closed this Mar 25, 2018
tniessen added a commit that referenced this pull request Mar 25, 2018
@tniessen
Revert "process: add more version properties to release"
eeb1b9d 
This reverts commit 982e3bd. It is
believed that the original PR should not have landed as it is as the
implemented and exposed API has a variety of flaws.

PR-URL: #19577
Refs: #19438
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsnek devsnek devsnek approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tniessen @jasnell @targos @cjihrig @richardlau @devsnek @nodejs-github-bot