Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errors: alter and test ERR_TLS_REQUIRED_SERVER_NAME #19988

Closed
wants to merge 2 commits into from
Closed

errors: alter and test ERR_TLS_REQUIRED_SERVER_NAME #19988

wants to merge 2 commits into from

Commits on Nov 14, 2018

  1. errors: alter and test ERR_TLS_REQUIRED_SERVER_NAME 

    changes the base instance for ERR_TLS_REQUIRED_SERVER_NAME
from Error to TypeError as a more accurate representation
of the error and adds a unit test for missing servername
input that triggers this error in Server.prototype.addContext
    @Trott
    davidmarkclements authored and Trott committed Nov 14, 2018
    Configuration menu
    Copy the full SHA
    4ba80ce View commit details
    Browse the repository at this point in the history

  2. test: remove ERR_TLS_REQUIRED_SERVER_NAME 

    Replace ERR_TLS_REQUIRED_SERVER_NAME with ERR_MISSING_ARGS. Update
tls.md documentation so that argument name in documentation reflects the
argument name in code.
    @Trott
    Trott committed Nov 14, 2018
    Configuration menu
    Copy the full SHA
    4f4d2fa View commit details
    Browse the repository at this point in the history