test: remove message from strictEqual assertions #20067
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If values are not equals in strictEqual assertions, an AssertionError is thrown with a message property set equals to the value of the message parameter. If we pass a message, this message will be printed instead of the default message, which contains the value that is causing the error. Hence removed the value passed as the message in strictEqual assertions of test/parallel/test-http-response-readable.js
cjihrig
approved these changes
Apr 16, 2018
BridgeAR
approved these changes
Apr 16, 2018
BridgeAR
added
the
author ready
jasnell
approved these changes
Apr 16, 2018
richardlau
approved these changes
Apr 16, 2018
Trott
approved these changes
Apr 16, 2018
|
Re-running Linux: https://ci.nodejs.org/job/node-test-commit-linux/18065/ |
trivikr
approved these changes
Apr 18, 2018
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 18, 2018
If values are not equals in strictEqual assertions, an AssertionError is thrown with a message property set equals to the value of the message parameter. If we pass a message, this message will be printed instead of the default message, which contains the value that is causing the error. Hence removed the value passed as the message in strictEqual assertions of test/parallel/test-http-response-readable.js PR-URL: nodejs#20067 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
|
Landed in f565bbb. Thanks for the contribution! 🎉 |
jasnell
pushed a commit
that referenced
this pull request
Apr 19, 2018
If values are not equals in strictEqual assertions, an AssertionError is thrown with a message property set equals to the value of the message parameter. If we pass a message, this message will be printed instead of the default message, which contains the value that is causing the error. Hence removed the value passed as the message in strictEqual assertions of test/parallel/test-http-response-readable.js PR-URL: #20067 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If values are not equals in strictEqual assertions, an AssertionError is
thrown with a message property set equals to the value of the message
parameter. If we pass a message, this message will be printed instead of
the default message, which contains the value that is causing the error.
Hence removed the value passed as the message in strictEqual assertions
of test/parallel/test-http-response-readable.js
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes