Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix inconsistency in documentation for building #20091

Closed
wants to merge 1 commit into from
Closed

doc: fix inconsistency in documentation for building #20091

wants to merge 1 commit into from

Conversation

spwg
Copy link
Contributor

@spwg spwg commented Apr 17, 2018

Specifically, fix the inconsistency where the documentation
suggests running "$ make test" instead of "$ make -j4 test".
The "-j4" flag uses multiple processes, making the command
faster.

Fixes: #19919

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Specifically, fix the inconsistency where the documentation
suggests running "$ make test" instead of "$ make -j4 test".
The "-j4" flag uses multiple processes, making the command
faster.

Fixes: #19919
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Apr 17, 2018
@vsemozhetbyt
Copy link
Contributor

@Trott Trott added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 17, 2018
@spwg
Copy link
Contributor Author

spwg commented Apr 20, 2018

Is there a reason this hasn't landed yet? It's been three days and it has several approvals, and I thought those were the rules in pull-requests.md? Thanks!

trivikr pushed a commit that referenced this pull request Apr 20, 2018
Specifically, fix the inconsistency where the documentation
suggests running "$ make test" instead of "$ make -j4 test".
The "-j4" flag uses multiple processes, making the command
faster.

Fixes: #19919

PR-URL: #20091
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@trivikr
Copy link
Member

trivikr commented Apr 20, 2018

Landed in a456775

Congratulations @spwg on your first commit in Node.js core! 🎉🎉🎉

@trivikr trivikr closed this Apr 20, 2018
@spwg spwg deleted the docs-update branch April 20, 2018 15:06
jasnell pushed a commit that referenced this pull request Apr 20, 2018
Specifically, fix the inconsistency where the documentation
suggests running "$ make test" instead of "$ make -j4 test".
The "-j4" flag uses multiple processes, making the command
faster.

Fixes: #19919

PR-URL: #20091
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc: make test commands a little more consistent
9 participants