Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: cover extra load-via-special-symbol scenario #20186

Closed
wants to merge 1 commit into from
Closed

src: cover extra load-via-special-symbol scenario #20186

wants to merge 1 commit into from

Conversation

gabrielschulhof
Copy link
Contributor

We need to look for a special symbol even if the module self-registers
when the module self-registers with the wrong version.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Re #20161

src: cover extra load-via-special-symbol scenario
c951284 
We need to look for a special symbol even if the module self-registers
when the module self-registers with the wrong version.
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Apr 21, 2018
@joyeecheung
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/14420/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 21, 2018
@gabrielschulhof
Copy link
Contributor Author

Landed in c1078c4.

gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 23, 2018
src: cover extra load-via-special-symbol scenario
c1078c4 
We need to look for a special symbol even if the module self-registers
when the module self-registers with the wrong version.

PR-URL: nodejs#20186
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@gabrielschulhof gabrielschulhof deleted the addon-special-symbol branch April 23, 2018 13:00
jasnell pushed a commit that referenced this pull request Apr 23, 2018
@jasnell
src: cover extra load-via-special-symbol scenario
6949543 
We need to look for a special symbol even if the module self-registers
when the module self-registers with the wrong version.

PR-URL: #20186
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gabrielschulhof @joyeecheung @bnoordhuis @BridgeAR @nodejs-github-bot