Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs/promises: ensure options.flag is defaulted to 'r' in readFile #20268

Closed
wants to merge 4 commits into from

Commits on May 9, 2018

  1. fs/promises: ensure options.flag is defaulted to 'r' in readFile

    When passing {} or { encoding: 'utf8' } as options to readFile, the
    flag is not defaulted to 'r' unlike normal fs. This fix makes
    (fs/promises).readFile() act consistently with fs.readFile().
    bdistin committed May 9, 2018
    Configuration menu
    Copy the full SHA
    f5a462f View commit details
    Browse the repository at this point in the history

Commits on May 27, 2018

  1. test: requested change

    fail on unhandled rejection
    bdistin committed May 27, 2018
    Configuration menu
    Copy the full SHA
    26bce85 View commit details
    Browse the repository at this point in the history
  2. test: fix requested change

    common was required, but not assigned to common in order for the requested change to work.
    bdistin committed May 27, 2018
    Configuration menu
    Copy the full SHA
    ca44fc2 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2018

  1. fs: return string on empty fs.promises.readFile() when encoding provided

    fs: return string on empty fs.promises.readfile when encoding provided
    
    fs.promises.readfile() would provide a buffer whenever an empty file
    is read, when it should have returned an empty string when encoding
    is provided.
    bdistin committed May 28, 2018
    Configuration menu
    Copy the full SHA
    543f297 View commit details
    Browse the repository at this point in the history