VS 2015 support #2036
Merged
VS 2015 support #2036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if defined noprojgen goto msbuild | ||
|
|
||
| @rem Generate the VS project. | ||
| python configure %download_arg% %i18n_arg% %debug_arg% %nosnapshot_arg% %noetw_arg% %noperfctr_arg% --dest-cpu=%target_arch% --tag=%TAG% |
There was a problem hiding this comment.
Cherry-picking leftover... %nosnapshot_arg% should be %snapshot_arg%
|
Thanks @orangemocha, decided that they belong in a separate commit rather than amending the cherry-pick |
|
LGTM |
mscdex
added
windows
|
ran another CI against this and got this on win2008 only: @Fishrock123 you're deep in timers now, does this fit into any existing context we have? I'm not sure if this has shown up before or not. Merging regardless because this is unrelated. |
vcbuild.bat calls python configure before setting GYP_MSVS_VERSION, so SelectVisualStudioVersion (tools\gyp\pylib\gyp\MSVSVersion.py) defaults to 'auto' and selects VS 2005. vcbuild sets the environment in the current shell, so this issue would manifest itself only on the first invocation of the script in any given shell windows. Reviewed-By: Julien Gilli <jgilli@fastmail.fm> PR-URL: nodejs/node-v0.x-archive#20109
PR-URL: nodejs#2036 Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
PR-URL: nodejs#2036 Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
|
@rvagg Yes, that happens sometimes. It's a minor bug somewhere very deep in windows libuv that will cause timers to occasionally fire quite early. Or something along those lines anyways. I think @orangemocha knew a bit more. |
|
Hi sorry, I just got around to installing VS2015 on my desktop yesterday. Nice work! |
rvagg
added a commit
to rvagg/io.js
that referenced
this pull request
Jun 25, 2015
PR-URL: nodejs#2036 Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
rvagg
added a commit
to rvagg/io.js
that referenced
this pull request
Jun 25, 2015
PR-URL: nodejs#2036 Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
Yes, that issue has been around for a while and that test is marked as flaky in joyent\node. nodejs/node-v0.x-archive#8960 We have been working on a fix (libuv/libuv#385), but it's still work in progress. |
Merged
rvagg
added a commit
that referenced
this pull request
Jun 26, 2015
PR-URL: #2036 Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
rvagg
added a commit
that referenced
this pull request
Jun 26, 2015
PR-URL: #2036 Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
rvagg
added a commit
that referenced
this pull request
Jun 26, 2015
PR-URL: #2036 Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
rvagg
added a commit
that referenced
this pull request
Jun 26, 2015
PR-URL: #2036 Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
rvagg
added a commit
to rvagg/io.js
that referenced
this pull request
Jul 3, 2015
PR-URL: nodejs#2036 Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
rvagg
added a commit
to rvagg/io.js
that referenced
this pull request
Jul 3, 2015
PR-URL: nodejs#2036 Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
joaocgreis
pushed a commit
to nodejs/node-v0.x-archive
that referenced
this pull request
Aug 24, 2015
This is a port of nodejs/node@4208dc4 . Original commit message: PR-URL: nodejs/node#2036 Reviewed-By: Alexis Campailla <alexis@janeasystems.com> PR-URL: #25857 Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
joaocgreis
pushed a commit
to JaneaSystems/node
that referenced
this pull request
Sep 12, 2015
This is a port of 4208dc4 . Original commit message: PR-URL: nodejs#2036 Reviewed-By: Alexis Campailla <alexis@janeasystems.com> This was ported to v0.10 in nodejs/node-v0.x-archive#25857
rvagg
added a commit
that referenced
this pull request
Sep 16, 2015
This is a port of 4208dc4 . Original commit message: PR-URL: #2036 Reviewed-By: Alexis Campailla <alexis@janeasystems.com> This was ported to v0.10 in nodejs/node-v0.x-archive#25857 PR-URL: #2843 Reviewed-By: rvagg - Rod Vagg <rod@vagg.org> Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org> Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
jBarz
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Nov 4, 2016
This is a port of 4208dc4 . Original commit message: PR-URL: nodejs/node#2036 Reviewed-By: Alexis Campailla <alexis@janeasystems.com> This was ported to v0.10 in nodejs#25857 PR-URL: nodejs/node#2843 Reviewed-By: rvagg - Rod Vagg <rod@vagg.org> Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org> Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues on from #478 but against master this time
/R=@nodejs/platform-windows