Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: improve fchmod{Sync} validation #20588

Merged
merged 2 commits into from
May 20, 2018
Merged

fs: improve fchmod{Sync} validation #20588

merged 2 commits into from
May 20, 2018

Commits on May 20, 2018

  1. lib: support ranges in validateInt32() 

    This commit adds minimum and maximum value checks to the
validateInt32() validator.

PR-URL: nodejs#20588
Fixes: nodejs#20498
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    @cjihrig
    cjihrig committed May 20, 2018
    Configuration menu
    Copy the full SHA
    1c1b8ae View commit details
    Browse the repository at this point in the history

  2. fs: improve fchmod{Sync} validation 

    This commit validates the fd parameters to fs.fchmod{Sync} as
int32s instead of uint32s because they are ints in the binding
layer.

PR-URL: nodejs#20588
Fixes: nodejs#20498
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    @cjihrig
    cjihrig committed May 20, 2018
    Configuration menu
    Copy the full SHA
    1ae184a View commit details
    Browse the repository at this point in the history