Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vm: move emitExperimentalWarning #20593

Closed
wants to merge 1 commit into from
Closed

vm: move emitExperimentalWarning #20593

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented May 8, 2018

This commit moves emitExperimentalWarning into the second object
destructoring of require internal/util.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@danbev
vm: move emitExperimentalWarning
b671fa6 
This commit moves emitExperimentalWarning into the second object
destructoring of require internal/util.
@nodejs-github-bot nodejs-github-bot added the vm Issues and PRs related to the vm subsystem. label May 8, 2018
@danbev
Copy link
Contributor Author

danbev commented May 8, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/14713/

@BridgeAR BridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label May 8, 2018
@addaleax
Copy link
Member

addaleax commented May 9, 2018

Landed in facb2c5

@addaleax addaleax closed this May 9, 2018
addaleax pushed a commit that referenced this pull request May 9, 2018
@danbev @addaleax
vm: move emitExperimentalWarning
facb2c5 
This commit moves emitExperimentalWarning into the second object
destructoring of require internal/util.

PR-URL: #20593
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request May 12, 2018
@danbev @targos
vm: move emitExperimentalWarning
8604481 
This commit moves emitExperimentalWarning into the second object
destructoring of require internal/util.

PR-URL: #20593
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@addaleax addaleax mentioned this pull request May 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@devsnek devsnek devsnek approved these changes

@maclover7 maclover7 maclover7 approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@jasnell jasnell jasnell approved these changes

@ChALkeR ChALkeR ChALkeR approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.