From b072d74162a33e95c99b957265b8178536e5dc05 Mon Sep 17 00:00:00 2001 From: Ujjwal Sharma Date: Thu, 7 Jun 2018 22:51:47 +0530 Subject: [PATCH 1/4] v8: replace Buffer with FastBuffer in deserialize Replace the Buffer constructor with a FastBuffer in v8.deserialize in order to avoid calling the Buffer constructor and thus triggering a deprecation warning from code inside the core. Fixes: https://github.com/nodejs/node/issues/21181 --- lib/v8.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/v8.js b/lib/v8.js index ed93b094ca7895..0d9ffc6033ced2 100644 --- a/lib/v8.js +++ b/lib/v8.js @@ -143,7 +143,7 @@ const arrayBufferViewTypeToIndex = new Map(); } } -const bufferConstructorIndex = arrayBufferViewTypes.push(Buffer) - 1; +const bufferConstructorIndex = arrayBufferViewTypes.push(FastBuffer) - 1; class DefaultSerializer extends Serializer { constructor() { From 84414b2192154d012de784e739423006beadd983 Mon Sep 17 00:00:00 2001 From: Ujjwal Sharma Date: Thu, 7 Jun 2018 23:33:47 +0530 Subject: [PATCH 2/4] fixup! v8: replace Buffer with FastBuffer in deserialize --- test/parallel/test-v8-deserialize-buffer.js | 8 ++++++++ 1 file changed, 8 insertions(+) create mode 100644 test/parallel/test-v8-deserialize-buffer.js diff --git a/test/parallel/test-v8-deserialize-buffer.js b/test/parallel/test-v8-deserialize-buffer.js new file mode 100644 index 00000000000000..0e1f89a4203420 --- /dev/null +++ b/test/parallel/test-v8-deserialize-buffer.js @@ -0,0 +1,8 @@ +'use strict'; + +const common = require('../common'); +const assert = require('assert'); +const v8 = require('v8'); + +process.on('warning', common.mustNotCall()); +v8.deserialize(v8.serialize(Buffer.alloc(0))); From c98b7b1c6b09b05cedbb540cb6838fbf8061c864 Mon Sep 17 00:00:00 2001 From: Ujjwal Sharma Date: Fri, 8 Jun 2018 11:18:23 +0530 Subject: [PATCH 3/4] fixup! v8: replace Buffer with FastBuffer in deserialize --- test/parallel/test-v8-deserialize-buffer.js | 1 + 1 file changed, 1 insertion(+) diff --git a/test/parallel/test-v8-deserialize-buffer.js b/test/parallel/test-v8-deserialize-buffer.js index 0e1f89a4203420..2e163b36832a80 100644 --- a/test/parallel/test-v8-deserialize-buffer.js +++ b/test/parallel/test-v8-deserialize-buffer.js @@ -1,3 +1,4 @@ +// Flags: --pending-deprecation --no-warnings 'use strict'; const common = require('../common'); From 7e39fd124d4d3870c7a2da04edafa559458367e9 Mon Sep 17 00:00:00 2001 From: Ujjwal Sharma Date: Mon, 11 Jun 2018 21:35:46 +0530 Subject: [PATCH 4/4] fixup! v8: replace Buffer with FastBuffer in deserialize --- test/parallel/test-v8-deserialize-buffer.js | 1 - 1 file changed, 1 deletion(-) diff --git a/test/parallel/test-v8-deserialize-buffer.js b/test/parallel/test-v8-deserialize-buffer.js index 2e163b36832a80..b6438027bafbfd 100644 --- a/test/parallel/test-v8-deserialize-buffer.js +++ b/test/parallel/test-v8-deserialize-buffer.js @@ -2,7 +2,6 @@ 'use strict'; const common = require('../common'); -const assert = require('assert'); const v8 = require('v8'); process.on('warning', common.mustNotCall());