Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix missing parentPort link in worker_threads #21430

Closed
wants to merge 1 commit into from
Closed

doc: fix missing parentPort link in worker_threads #21430

wants to merge 1 commit into from

Conversation

watson
Copy link
Member

@watson watson commented Jun 20, 2018

Checklist

@nodejs-github-bot
Copy link
Collaborator

@watson build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/109/pipeline

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 20, 2018
@watson watson requested a review from addaleax June 20, 2018 22:08
@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt vsemozhetbyt added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. worker Issues and PRs related to Worker support. fast-track PRs that do not need to wait for 48 hours to land. labels Jun 20, 2018
@watson
Copy link
Member Author

watson commented Jun 21, 2018 •
edited by lpinca
Loading

Landed in 182ee78

@watson watson closed this Jun 21, 2018
@watson watson deleted the missinglink branch June 21, 2018 09:51
watson added a commit that referenced this pull request Jun 21, 2018
@watson
doc: fix missing parentPort link in worker_threads
182ee78 
PR-URL: #21430
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@joyeecheung joyeecheung mentioned this pull request Jun 21, 2018
Closed
targos pushed a commit that referenced this pull request Jun 22, 2018
@watson @targos
doc: fix missing parentPort link in worker_threads
9e31684 
PR-URL: #21430
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Jul 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@watson @nodejs-github-bot @vsemozhetbyt @addaleax @lpinca