child_process: fix arguments comments #2161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverwind
added
child_process
|
The changes look fine, but it might not be worth the noise. |
|
LGTMT. But do we have a policy against landing just cosmetic changes? |
|
Fixing the fact that the commented arguments were incorrect seems more than cosmetic to me. |
silverwind
added a commit
that referenced
this pull request
Jul 11, 2015
Fixes the arguments comments for execFileSync and other related minor inconsistencies in commented arguments in the same file. PR-URL: #2161 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in 5acad6b. I think it was worth it as I can't remember which of the spawn variants take |
| @@ -443,7 +443,7 @@ function checkExecSyncError(ret) { | |||
| } | |||
|
|
|||
|
|
|||
| function execFileSync(/*command, options*/) { | |||
| function execFileSync(/*command, args, options*/) { | |||
There was a problem hiding this comment.
Not sure if the rest should have been done but this one was worthwhile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the noise. While reading through child_process.js, I noticed the commented arguments to
execFileSyncwere wrong. I also found some style inconsistencies and a typo while looking through the other argument comments.