Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove useless comments #21638

Closed
wants to merge 1 commit into from
Closed

test: remove useless comments #21638

wants to merge 1 commit into from

Conversation

jpospychala
Copy link

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows [commit guidelines]

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 3, 2018
@Trott
Copy link
Member

Trott commented Jul 3, 2018

Might be good to change useless comments to unnecessary string literals but that can happen when someone lands this or for that matter not at all.

@Trott
Copy link
Member

Trott commented Jul 3, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/15712/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 3, 2018
mhdawson
mhdawson approved these changes Jul 5, 2018
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Trott pushed a commit to Trott/io.js that referenced this pull request Jul 5, 2018
@Trott
test: remove unnecessary string literals
a64b2f2 
PR-URL: nodejs#21638
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@Trott
Copy link
Member

Trott commented Jul 5, 2018 •
edited
Loading

Landed in a64b2f2 .

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, come ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Jul 5, 2018
targos pushed a commit that referenced this pull request Jul 6, 2018
@targos
test: remove unnecessary string literals
021dd54 
PR-URL: #21638
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@targos targos mentioned this pull request Jul 17, 2018
Merged
This was referenced Jul 18, 2018
Closed
Closed
Closed
Closed
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 18, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@mhdawson mhdawson mhdawson approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jpospychala @Trott @addaleax @lpinca @cjihrig @mhdawson @trivikr @nodejs-github-bot