-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: patch V8 to 6.7.288.49 #21727
deps: patch V8 to 6.7.288.49 #21727
Conversation
It doesn’t look like these changes affect us, right? I guess it’s not an issue if you’re a Googler, but if your dev machine is near the lower end, recompiling all of V8 can be a real pain… |
@addaleax we can hold off on landing this one and wait for changes that are more meaningful, generally trying to just keep us up to date with LKGR. Do these changes force a recompile? |
I guess not, no … seems okay to me then? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rubber-stamp lgtm
landed in 9374a83 |
PR-URL: #21727 Refs: v8/v8@6.7.288.46...6.7.288.49 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #21727 Refs: v8/v8@6.7.288.46...6.7.288.49 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Refs: v8/v8@6.7.288.46...6.7.288.49