Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8.x-backport] n-api: throw when entry point is null #21732

Closed
wants to merge 1 commit into from
Closed

[v8.x-backport] n-api: throw when entry point is null #21732

wants to merge 1 commit into from

Conversation

gabrielschulhof
Copy link
Contributor

PR-URL: #20779

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@gabrielschulhof build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/239/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v4.x node-api Issues and PRs related to the Node-API. labels Jul 10, 2018
@gabrielschulhof
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/15777/

@gabrielschulhof
Copy link
Contributor Author

Resumed as: https://ci.nodejs.org/job/node-test-pull-request/15780/

@gabrielschulhof
Copy link
Contributor Author

Resume Build doesn't seem to work for node-test-commit-windows-fanned.

@MylesBorins
Copy link
Contributor

@gabrielschulhof can you please rebase against v8.x-staging

n-api: throw when entry point is null
d4e5de2 
PR-URL: nodejs#20779
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@gabrielschulhof
Copy link
Contributor Author

@MylesBorins done.

@MylesBorins
Copy link
Contributor

one more ci: https://ci.nodejs.org/job/node-test-pull-request/16099/

MylesBorins pushed a commit that referenced this pull request Aug 1, 2018
@MylesBorins
n-api: throw when entry point is null
b48791d 
Backport-PR-URL: #21732
PR-URL: #20779
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins
Copy link
Contributor

Failures are known flakes

b48791d

@MylesBorins MylesBorins closed this Aug 1, 2018
@gabrielschulhof gabrielschulhof mentioned this pull request Aug 8, 2018
Closed
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@rvagg
n-api: throw when entry point is null
7033bba 
Backport-PR-URL: #21732
PR-URL: #20779
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@gabrielschulhof gabrielschulhof deleted the backport-20779-to-v8.x branch June 14, 2019 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gabrielschulhof @nodejs-github-bot @MylesBorins @Trott