From 7acd583639c4fa388e72e492a77b37a9bd61b37c Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Thu, 6 Sep 2018 22:31:07 +0200 Subject: [PATCH] tracing: remove shutdown-on-signal MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This feature cannot be reasonably implemented this way without inherently being susceptible to race conditions that lead to hangs, crashes, etc. What’s more, implementing this for some signals only (and it can only be implemented for some signals at all) may lead to the impression that it is a guaranteed feature, when really consumers of the tracing output *need* to be able to handle abrupt ends meaningfully. Fixes: https://github.com/nodejs/node/issues/14802 Fixes: https://github.com/nodejs/node/issues/22528 --- src/node.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/src/node.cc b/src/node.cc index d1ce0ce1af3870..e8ba27234b7c15 100644 --- a/src/node.cc +++ b/src/node.cc @@ -2200,7 +2200,6 @@ void SetupProcessObject(Environment* env, void SignalExit(int signo) { uv_tty_reset_mode(); - v8_platform.StopTracingAgent(); #ifdef __FreeBSD__ // FreeBSD has a nasty bug, see RegisterSignalHandler for details struct sigaction sa;