Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: expect test to fail in debug builds #22881

Closed
wants to merge 2 commits into from

Conversation

refack
Copy link
Contributor

@refack refack commented Sep 15, 2018

ATM This fails with V8 6.9. Should be fixed in 7.0.
Refs: #22775

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 15, 2018
@refack
Copy link
Contributor Author

refack commented Sep 15, 2018

First check that it solves the CI issue: https://ci.nodejs.org/job/node-test-commit-linux-containered/7082/

@Trott
Copy link
Member

Trott commented Sep 15, 2018

I'm confused by the fact that this test already results in a yellow result rather than red. ????

@refack
Copy link
Contributor Author

refack commented Sep 16, 2018

I'm confused by the fact that this test already results in a yellow result rather than red. ????

It's a bug/feature in the CI scripts for the "containered" configuration. During ramp up of those we set them to flag "unstable", and not "fail". We forgot to upgrade them.
ATM I did set them to flag "fail", all except the "debug" configuration. That's until we solve this.

@richardlau
Copy link
Member

I'm confused by the fact that this test already results in a yellow result rather than red. ????

Will this change mark as green as it's expecting a fail rather than a flake?

@refack
Copy link
Contributor Author

refack commented Sep 16, 2018

Will this change mark as green as it's expecting a fail rather than a flake?

Yes. And once it's fixed (tests show V8 7.0 will fix this) it should turn red, so we'll know to remove this flag.

@addaleax
Copy link
Member

Closing, since the fix in #22890 has been landed :)

@addaleax addaleax closed this Sep 18, 2018
@refack refack deleted the expext-mapsame-to-fail-in-debug branch September 18, 2018 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants