Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove common.hasSmallICU #22937

Closed
wants to merge 1 commit into from
Closed

test: remove common.hasSmallICU #22937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions test/common/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,11 +158,6 @@ Indicates `hasCrypto` and `crypto` with fips.

Indicates if [internationalization] is supported.

### hasSmallICU
* [<boolean>]

Indicates `hasIntl` and `small-icu` are supported.

### hasIPv6
* [<boolean>]

Expand Down
4 changes: 1 addition & 3 deletions test/common/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ const { fixturesDir } = require('./fixtures');
const tmpdir = require('./tmpdir');
const {
bits,
hasIntl,
hasSmallICU
hasIntl
} = process.binding('config');

const noop = () => {};
Expand Down Expand Up @@ -715,7 +714,6 @@ module.exports = {
hasIntl,
hasCrypto,
hasIPv6,
hasSmallICU,
hasMultiLocalhost,
isAIX,
isAlive,
Expand Down
4 changes: 3 additions & 1 deletion test/parallel/test-icu-data-dir.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
'use strict';
const common = require('../common');
const os = require('os');
if (!(common.hasIntl && common.hasSmallICU))

const { hasSmallICU } = process.binding('config');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bonus points: process.config.variables.icu_small

if (!(common.hasIntl && hasSmallICU))
common.skip('missing Intl');

const assert = require('assert');
Expand Down