Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: patch V8 to 7.0.276.28 #23424

Closed
wants to merge 2 commits into from
Closed

deps: patch V8 to 7.0.276.28 #23424

wants to merge 2 commits into from

Conversation

targos
Copy link
Member

@targos targos commented Oct 11, 2018

Refs: v8/v8@7.0.276.25...7.0.276.27

@nodejs/v8-update

@targos targos added v8 engine Issues and PRs related to the V8 dependency. dont-land-on-v6.x labels Oct 11, 2018
@nodejs-github-bot
Copy link
Collaborator

@targos build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1202/pipeline

@targos
Copy link
Member Author

targos commented Oct 11, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17743/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/1753/

refack
refack approved these changes Oct 11, 2018
View reviewed changes
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@refack refack mentioned this pull request Oct 12, 2018
Closed
@targos targos changed the title deps: patch V8 to 7.0.276.27 deps: patch V8 to 7.0.276.28 Oct 16, 2018
@targos
Copy link
Member Author

targos commented Oct 16, 2018

Bumped to patch version 28. I'll squash the commits while landing.

New CI: https://ci.nodejs.org/job/node-test-pull-request/17892/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/1762/

@jasnell jasnell added this to the 11.0.0 milestone Oct 16, 2018
@refack
Copy link
Contributor

refack commented Oct 16, 2018 •
edited
Loading

CI fail is a known flake #23277

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/17907/

@refack refack added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 16, 2018
@targos
Copy link
Member Author

targos commented Oct 16, 2018

Landed in 0272c9d

@jasnell Chrome 70 went stable today and has this version.

targos added a commit that referenced this pull request Oct 16, 2018
@targos
deps: patch V8 to 7.0.276.28
0272c9d 
Refs: v8/v8@7.0.276.25...7.0.276.28

PR-URL: #23424
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
@targos targos closed this Oct 16, 2018
@targos targos deleted the update-v8 branch October 16, 2018 19:20
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@targos @jasnell
deps: patch V8 to 7.0.276.28
e2258ad 
Refs: v8/v8@7.0.276.25...7.0.276.28

PR-URL: #23424
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@hashseed hashseed hashseed approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

@ofrobots ofrobots ofrobots approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@targos @nodejs-github-bot @refack @ofrobots @jasnell @addaleax @hashseed @cjihrig