Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: updating assertion on test so it fits the new method signature #23536

Closed
wants to merge 1 commit into from
Closed

test: updating assertion on test so it fits the new method signature #23536

wants to merge 1 commit into from

Conversation

leomoreno
Copy link
Contributor

One assertion on test-tls-connect-address-family.js was out fo date,
here we are fixing it to match the signature of strictEqual method.

Checklist
  • [ X ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [ X ] commit message follows commit guidelines

@leomoreno
test: updating assertion on test so it fits the new method signature
2827090 
One assertion on test-tls-connect-address-family.js was out fo date,
here we are fixing it to match the signature of strictEqual method.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 12, 2018
@targos targos added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 12, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Oct 15, 2018
@leomoreno @BridgeAR
test: updating assertion on test so it fits the new method signature
0fd7b34 
One assertion on test-tls-connect-address-family.js was out fo date,
here we are fixing it to match the signature of strictEqual method.

PR-URL: nodejs#23536
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Oct 15, 2018
@leomoreno @BridgeAR
test: updating assertion on test so it fits the new method signature
2d76dec 
One assertion on test-tls-connect-address-family.js was out fo date,
here we are fixing it to match the signature of strictEqual method.

PR-URL: nodejs#23536
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR
Copy link
Member

Landed in 2d76dec 🎉

@leomoreno congratulations on your commit to Node.js!

@BridgeAR BridgeAR closed this Oct 15, 2018
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@leomoreno @jasnell
test: updating assertion on test so it fits the new method signature
69365ef 
One assertion on test-tls-connect-address-family.js was out fo date,
here we are fixing it to match the signature of strictEqual method.

PR-URL: #23536
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax pushed a commit that referenced this pull request Oct 20, 2018
@leomoreno @addaleax
test: updating assertion on test so it fits the new method signature
2e86c7e 
One assertion on test-tls-connect-address-family.js was out fo date,
here we are fixing it to match the signature of strictEqual method.

PR-URL: #23536
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
@leomoreno @MylesBorins
test: updating assertion on test so it fits the new method signature
de8ffba 
One assertion on test-tls-connect-address-family.js was out fo date,
here we are fixing it to match the signature of strictEqual method.

PR-URL: #23536
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@leomoreno @rvagg
test: updating assertion on test so it fits the new method signature
8c24a63 
One assertion on test-tls-connect-address-family.js was out fo date,
here we are fixing it to match the signature of strictEqual method.

PR-URL: #23536
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@leomoreno @MylesBorins
test: updating assertion on test so it fits the new method signature
a665e3a 
One assertion on test-tls-connect-address-family.js was out fo date,
here we are fixing it to match the signature of strictEqual method.

PR-URL: #23536
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@leomoreno @BridgeAR @jasnell @cjihrig @gireeshpunathil @trivikr @targos @nodejs-github-bot