From 704bc13f88b9d798915c0faa98e9d3d5a02eebe2 Mon Sep 17 00:00:00 2001 From: Kayla Altepeter Date: Fri, 12 Oct 2018 11:28:54 -0700 Subject: [PATCH 1/4] test: adding test coverage for SourceTextModule.evaluate This checks that invalid option throws an error. --- test/parallel/test-vm-module-errors.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/test/parallel/test-vm-module-errors.js b/test/parallel/test-vm-module-errors.js index 6803e0d86b3ff4..c036e4b294eb52 100644 --- a/test/parallel/test-vm-module-errors.js +++ b/test/parallel/test-vm-module-errors.js @@ -131,6 +131,14 @@ async function checkModuleState() { message: 'Module status must be one of instantiated, evaluated, and errored' }); + await expectsRejection(async () => { + const m = new SourceTextModule(''); + await m.evaluate(false); + }, { + code: 'ERR_INVALID_ARG_TYPE', + message: 'The "options" argument must be of type Object. Received type boolean' + }); + await expectsRejection(async () => { const m = await createEmptyLinkedModule(); await m.evaluate(); From e0098f96b7c815e8e6c833170cfbaf2fa7b89b63 Mon Sep 17 00:00:00 2001 From: Kayla Altepeter Date: Fri, 12 Oct 2018 11:36:52 -0700 Subject: [PATCH 2/4] fixup: fixing lint line length --- test/parallel/test-vm-module-errors.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/parallel/test-vm-module-errors.js b/test/parallel/test-vm-module-errors.js index c036e4b294eb52..0c5c024db6ce43 100644 --- a/test/parallel/test-vm-module-errors.js +++ b/test/parallel/test-vm-module-errors.js @@ -136,7 +136,8 @@ async function checkModuleState() { await m.evaluate(false); }, { code: 'ERR_INVALID_ARG_TYPE', - message: 'The "options" argument must be of type Object. Received type boolean' + message: 'The "options" argument must be of type Object. ' + + 'Received type boolean' }); await expectsRejection(async () => { From b5191a5e2e85c8c824b98adf48cb52663389c5a5 Mon Sep 17 00:00:00 2001 From: Kayla Altepeter Date: Fri, 12 Oct 2018 11:39:14 -0700 Subject: [PATCH 3/4] fixup: fixing line spacing --- test/parallel/test-vm-module-errors.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/parallel/test-vm-module-errors.js b/test/parallel/test-vm-module-errors.js index 0c5c024db6ce43..a6acddaeff6dde 100644 --- a/test/parallel/test-vm-module-errors.js +++ b/test/parallel/test-vm-module-errors.js @@ -137,7 +137,7 @@ async function checkModuleState() { }, { code: 'ERR_INVALID_ARG_TYPE', message: 'The "options" argument must be of type Object. ' + - 'Received type boolean' + 'Received type boolean' }); await expectsRejection(async () => { From 5f9d6cd4907e40147decdb54be753873e2e265ff Mon Sep 17 00:00:00 2001 From: Kayla Altepeter Date: Fri, 12 Oct 2018 11:43:47 -0700 Subject: [PATCH 4/4] fixup: fix spacing --- test/parallel/test-vm-module-errors.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/parallel/test-vm-module-errors.js b/test/parallel/test-vm-module-errors.js index a6acddaeff6dde..a6b2a6e797a1bb 100644 --- a/test/parallel/test-vm-module-errors.js +++ b/test/parallel/test-vm-module-errors.js @@ -137,7 +137,7 @@ async function checkModuleState() { }, { code: 'ERR_INVALID_ARG_TYPE', message: 'The "options" argument must be of type Object. ' + - 'Received type boolean' + 'Received type boolean' }); await expectsRejection(async () => {