Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark test-http2-session-timeout as flake on ARM #23639

Closed
wants to merge 1 commit into from
Closed

test: mark test-http2-session-timeout as flake on ARM #23639

wants to merge 1 commit into from

Conversation

refack
Copy link
Contributor

@refack refack commented Oct 13, 2018 •
edited
Loading

Refs: #20628

Please 👍 to fast-track

CI: https://ci.nodejs.org/job/node-test-pull-request/17810/
https://ci.nodejs.org/job/node-test-pull-request/17812/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@refack refack added test Issues and PRs related to the tests. flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. labels Oct 13, 2018
@refack refack self-assigned this Oct 13, 2018
@refack refack requested a review from Trott October 13, 2018 14:22
@nodejs-github-bot
Copy link
Collaborator

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1227/pipeline

@refack
Copy link
Contributor Author

refack commented Oct 13, 2018 •
edited
Loading

/CC @nodejs/testing @nodejs/http2 @nodejs/platform-arm

@refack refack mentioned this pull request Oct 13, 2018
Closed
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 13, 2018
@addaleax
Copy link
Member

Landed in 882e022

@addaleax addaleax closed this Oct 13, 2018
addaleax pushed a commit that referenced this pull request Oct 13, 2018
@refack @addaleax
test: mark test-http2-session-timeout as flake on ARM
882e022 
PR-URL: #23639
Refs: #20628
Reviewed-By: Rich Trott <rtrott@gmail.com>
@refack refack removed their assignment Oct 13, 2018
@refack refack deleted the mark-new-flake branch October 13, 2018 18:53
addaleax pushed a commit that referenced this pull request Oct 14, 2018
@refack @addaleax
test: mark test-http2-session-timeout as flake on ARM
59ecf06 
PR-URL: #23639
Refs: #20628
Reviewed-By: Rich Trott <rtrott@gmail.com>
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@refack @jasnell
test: mark test-http2-session-timeout as flake on ARM
5e68333 
PR-URL: #23639
Refs: #20628
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
@refack @MylesBorins
test: mark test-http2-session-timeout as flake on ARM
75d4bf2 
PR-URL: #23639
Refs: #20628
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@refack @rvagg
test: mark test-http2-session-timeout as flake on ARM
9cfa1f6 
PR-URL: #23639
Refs: #20628
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@refack @MylesBorins
test: mark test-http2-session-timeout as flake on ARM
51aa50c 
PR-URL: #23639
Refs: #20628
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@refack @nodejs-github-bot @addaleax @Trott