From 1a79e37ebc0407581c093fac70a541d4d7b77ad5 Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Thu, 8 Nov 2018 13:27:39 -0500 Subject: [PATCH 1/4] build: lint commit message in separate Travis job Move the first commit message linting to a separate Travis job. Run the script in bash debug mode to capture any issues communicating with the GitHub API (e.g. network issues, rate limits). --- .travis.yml | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index 80c729a772fed5..f8035f0f6187ee 100644 --- a/.travis.yml +++ b/.travis.yml @@ -4,6 +4,13 @@ cache: ccache os: linux matrix: include: + - name: "Check First Commit Message" + language: node_js + node_js: "node" + script: + - if [ "${TRAVIS_PULL_REQUEST}" != "false" ]; then + bash -x tools/lint-pr-commit-message.sh ${TRAVIS_PULL_REQUEST}; + fi - name: "Linter" language: node_js node_js: "node" @@ -11,10 +18,6 @@ matrix: - NODE=$(which node) script: - make lint - # Lint the first commit in the PR. - - if [ "${TRAVIS_PULL_REQUEST}" != "false" ]; then - bash tools/lint-pr-commit-message.sh ${TRAVIS_PULL_REQUEST} || true; - fi - name: "Test Suite" addons: apt: From 295c5cfef7a0dc36069d6e2ae523c2ed11ce3d1b Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Thu, 8 Nov 2018 14:05:05 -0500 Subject: [PATCH 2/4] fixup! add link to guidelines in job name --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index f8035f0f6187ee..64769084372e20 100644 --- a/.travis.yml +++ b/.travis.yml @@ -4,7 +4,7 @@ cache: ccache os: linux matrix: include: - - name: "Check First Commit Message" + - name: "First commit message adheres to guidelines at https://goo.gl/p2fr5Q" language: node_js node_js: "node" script: From 5a01d5e5664889e8a8d1febf6b01b70379948c38 Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Thu, 8 Nov 2018 15:23:59 -0500 Subject: [PATCH 3/4] fixup! add condition to commit message job --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index 64769084372e20..5c0928477b2d66 100644 --- a/.travis.yml +++ b/.travis.yml @@ -5,6 +5,7 @@ os: linux matrix: include: - name: "First commit message adheres to guidelines at https://goo.gl/p2fr5Q" + if: type = pull_request language: node_js node_js: "node" script: From 2857dbb485c31df99792171ed5a788121dc011a6 Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Thu, 8 Nov 2018 15:37:21 -0500 Subject: [PATCH 4/4] fixup! try html in job name --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 5c0928477b2d66..e496919579b2f8 100644 --- a/.travis.yml +++ b/.travis.yml @@ -4,7 +4,7 @@ cache: ccache os: linux matrix: include: - - name: "First commit message adheres to guidelines at https://goo.gl/p2fr5Q" + - name: "First commit message adheres to guidelines at https://goo.gl/p2fr5Q" if: type = pull_request language: node_js node_js: "node"