From 24e7827ad60679240c0f7bc680be1f5ab664f5a8 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Sun, 25 Nov 2018 20:04:53 -0800 Subject: [PATCH 1/2] doc: revise accepting-modifications in guide Revise the "Accepting Modifications" section of the Collaborator Guide. --- COLLABORATOR_GUIDE.md | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 90d52105a74219..8f0f4b94263ea8 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -93,12 +93,9 @@ to land but is [author ready](#author-ready-pull-requests), add the ## Accepting Modifications -All modifications to the Node.js code and documentation should be performed via -GitHub pull requests, including modifications by Collaborators and TSC members. -A pull request must be reviewed, and must also be tested with CI, before being -landed into the codebase. There may be exceptions to the latter (the changed -code cannot be tested with a CI or similar). If that is the case, please leave a -comment that explains why the PR does not require a CI run. +All modifications to Node.js start as GitHub pull requests. This includes +modifications by Collaborators (including TSC members). A pull request must pass +code review and CI before landing into the codebase. ### Code Reviews From 44ca697fe76df32e90d72878b4565bb925221f69 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Tue, 27 Nov 2018 19:12:58 -0800 Subject: [PATCH 2/2] fixup! doc: revise accepting-modifications in guide --- COLLABORATOR_GUIDE.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 8f0f4b94263ea8..867371356433a2 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -93,9 +93,10 @@ to land but is [author ready](#author-ready-pull-requests), add the ## Accepting Modifications -All modifications to Node.js start as GitHub pull requests. This includes -modifications by Collaborators (including TSC members). A pull request must pass -code review and CI before landing into the codebase. +Contributors propose modifications to Node.js using GitHub pull requests. This +is true for all modifications including those proposed by TSC members and other +Collaborators. A pull request must pass code review and CI before landing into +the codebase. ### Code Reviews