-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v11.4.0 proposal #24854
v11.4.0 proposal #24854
Commits on Nov 28, 2018
-
test: fix the arguments order in
assert.strictEqual
PR-URL: #24416 Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0a08cd7 - Browse repository at this point
Copy the full SHA 0a08cd7View commit details -
src: use STL containers instead of v8 values for static module data
Instead of putting the source code and the cache in v8::Objects, put them in per-process std::maps. This has the following benefits: - It's slightly lighter in weight compared to storing things on the v8 heap. Also it may be slightly faster since the preivous v8::Object is already in dictionary mode - though the difference is very small given the number of native modules is limited. - The source and code cache generation templates are now much simpler since they just initialize static arrays and manipulate STL constructs. - The static native module data can be accessed independently of any Environment or Isolate, and it's easy to look them up from the C++'s side. - It's now impossible to mutate the source code used to compile native modules from the JS land since it's completely separate from the v8 heap. We can still get the constant strings from process.binding('natives') but that's all. A few drive-by fixes: - Remove DecorateErrorStack in LookupAndCompile - We don't need to capture the exception to decorate when we encounter errors during native module compilation, as those errors should be syntax errors and v8 is able to decorate them well. We use CompileFunctionInContext so there is no need to worry about wrappers either. - The code cache could be rejected when node is started with v8 flags. Instead of aborting in that case, simply keep a record in the native_module_without_cache set. - Refactor js2c.py a bit, reduce code duplication and inline Render() to make the one-byte/two-byte special treatment easier to read. PR-URL: #24384 Fixes: https://github.com/Remove Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 21e9aa2 - Browse repository at this point
Copy the full SHA 21e9aa2View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd8be40 - Browse repository at this point
Copy the full SHA bd8be40View commit details -
test: fix arguments order in napi test_exception
PR-URL: #24413 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4348ffe - Browse repository at this point
Copy the full SHA 4348ffeView commit details -
test: replace anonymous closure functions with arrow function
PR-URL: #24417 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b1dee7d - Browse repository at this point
Copy the full SHA b1dee7dView commit details -
test: use print() function on both Python 2 and 3
PR-URL: #24485 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 957ecbe - Browse repository at this point
Copy the full SHA 957ecbeView commit details -
benchmark: pre-generate data set for URL benchmarks
This patch: - Introduces `common.bakeUrlData` which can be used to pre-generate the data set for the URL benchmarks to loop through instead of looping over a constant. - Add the option to use WPT data in benchmarks for better diversity in the input - Add the option to benchmark URL parsing with base URLs (whatwg only) - Moves the data in `benchmark/fixtures/url-inputs.js` to `benchmark/common.js` PR-URL: #24302 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f5d4db1 - Browse repository at this point
Copy the full SHA f5d4db1View commit details -
benchmark: support URL inputs in create-clientrequest
This patch adds the option in the create-clientrequest benchmark to accept URL inputs (as strings or as URL objects) so we can measure the impact of URL parsing in a more sophisticated use case. PR-URL: #24302 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ef63bb2 - Browse repository at this point
Copy the full SHA ef63bb2View commit details -
test: favor arrow functions in callbacks
PR-URL: #24425 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2f0a5b6 - Browse repository at this point
Copy the full SHA 2f0a5b6View commit details -
build: use print() function in configure.py
PR-URL: #24484 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 21e59a6 - Browse repository at this point
Copy the full SHA 21e59a6View commit details -
test: change anonymous closure functions to arrow functions
PR-URL: #24418 Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 237e479 - Browse repository at this point
Copy the full SHA 237e479View commit details -
test: add typeerror test for EC crypto keygen
PR-URL: #24400 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e9abf42 - Browse repository at this point
Copy the full SHA e9abf42View commit details -
Configuration menu - View commit details
-
Copy full SHA for a499db7 - Browse repository at this point
Copy the full SHA a499db7View commit details -
PR-URL: #24390 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b1622a2 - Browse repository at this point
Copy the full SHA b1622a2View commit details -
test: replace anonymous closure function with arrow function
PR-URL: #24435 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7d743e6 - Browse repository at this point
Copy the full SHA 7d743e6View commit details -
src: elevate v8 namespaces of node_trace_events.cc
PR-URL: #24469 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 216f751 - Browse repository at this point
Copy the full SHA 216f751View commit details -
test: replace closure with arrow functions
PR-URL: #24440 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3bfa953 - Browse repository at this point
Copy the full SHA 3bfa953View commit details -
lib: refactor setupInspector in bootstrap/node.js
`CJSModule` is not used in `setupGlobalConsole`, so we can move it to `setupInspector` and remove the argument from `setupInspector`. PR-URL: #24446 Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e14abfe - Browse repository at this point
Copy the full SHA e14abfeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ab2bcf - Browse repository at this point
Copy the full SHA 9ab2bcfView commit details -
util: remove unreachable branch
Re-defining the array length will always set to 0. Hence, the code branch can not be covered. PR-URL: #24447 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9e8f91d - Browse repository at this point
Copy the full SHA 9e8f91dView commit details -
build: remove sudo:false from .travis.yml
sudo:false is being removed by Travis CI. Travis CI recommends removing the configuration. Fixes: #24510 PR-URL: #24511 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 39614ad - Browse repository at this point
Copy the full SHA 39614adView commit details -
http2: order declarations in http2.js
PR-URL: #24411 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for 1f54499 - Browse repository at this point
Copy the full SHA 1f54499View commit details -
console: improve code readability
use object spread to make console code more readable PR-URL: #24412 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 50005e7 - Browse repository at this point
Copy the full SHA 50005e7View commit details -
doc: describe certificate object properties
PR-URL: #24358 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for dadc2eb - Browse repository at this point
Copy the full SHA dadc2ebView commit details -
tls: include elliptic curve X.509 public key info
X.509 certs are provided to the user in a parsed object form by a number of TLS APIs. Include public key info for elliptic curves as well, not just RSA. - pubkey: the public key - bits: the strength of the curve - asn1Curve: the ASN.1 OID for the curve - nistCurve: the NIST nickname for the curve, if it has one PR-URL: #24358 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 37f0bd7 - Browse repository at this point
Copy the full SHA 37f0bd7View commit details -
tls: include RSA bit size in X.509 public key info
For symmetricality with the EC public key info, and because its useful. PR-URL: #24358 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for f30c7c4 - Browse repository at this point
Copy the full SHA f30c7c4View commit details -
doc: add Beth Griggs to release team
PR-URL: #24532 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d345271 - Browse repository at this point
Copy the full SHA d345271View commit details -
doc: minor cleanup of tls.getProtocol()
Improve markup and return value description. PR-URL: #24533 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 48852cc - Browse repository at this point
Copy the full SHA 48852ccView commit details -
src: elevate namespaces of repeated artifacts
PR-URL: #24429 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b8ed930 - Browse repository at this point
Copy the full SHA b8ed930View commit details -
test: modify order of parameters for assertion
PR-URL: #24430 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ed714a2 - Browse repository at this point
Copy the full SHA ed714a2View commit details -
http2: replace unreachable error with assertion
"That particular `emit('error', ...)` is largely defensively coded and should not ever actually happen." Sounds like an assertion rather than an error event. The code in question has no test coverage because it is believed to be unreachable. Fixes: #20673 PR-URL: #24407 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f5e9bb1 - Browse repository at this point
Copy the full SHA f5e9bb1View commit details -
Previously, we use the Window scope by default in our WPT test runner. When one of the test fails, the WPT harness would try to use document.getElementsByTagName() etc. to display the failure, which is not going to work for us. This patch switches the scope to DedicatedWorker and use our Worker implementation as a global - this does not test the Worker implementation per se, just tells the WPT harness to pass the results back to us via the callbacks we installed and not try to access a document. We may still need to use a Window scope when we try to run .window.js tests in the future, but for now we only run .any.js tests so it's fine to use a worker scope by default. PR-URL: #24410 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for 33b5242 - Browse repository at this point
Copy the full SHA 33b5242View commit details -
Configuration menu - View commit details
-
Copy full SHA for b22e95d - Browse repository at this point
Copy the full SHA b22e95dView commit details -
cli: add missing env vars to --help
This adds NODE_TLS_REJECT_UNAUTHORIZED, SSL_CERT_DIR, SSL_CERT_FILE, and UV_THREADPOOL_SIZE to the --help menu. PR-URL: #24383 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for b214ae4 - Browse repository at this point
Copy the full SHA b214ae4View commit details -
doc: add missing env variables to man page
This commit adds the missing environment variables NODE_DEBUG_NATIVE, NODE_PRESERVE_SYMLINKS, NODE_TLS_REJECT_UNAUTHORIZED, NODE_V8_COVERAGE, and UV_THREADPOOL_SIZE to the man page. PR-URL: #24383 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 6e4a120 - Browse repository at this point
Copy the full SHA 6e4a120View commit details -
doc: add NODE_DEBUG_NATIVE to API docs
This commit adds the missing environment variable NODE_DEBUG_NATIVE to the CLI API docs. PR-URL: #24383 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 91494bf - Browse repository at this point
Copy the full SHA 91494bfView commit details -
lib: move encodeStr function to internal for reusable
PR-URL: #24242 Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for daeb348 - Browse repository at this point
Copy the full SHA daeb348View commit details -
doc: move Timothy to TSC emeritus
PR-URL: #24535 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6d147ef - Browse repository at this point
Copy the full SHA 6d147efView commit details -
test: add whatwg-encoding TextDecoder custom inspection with showHidden
These tests ensure hidden fields are shown when inspecting with `showHidden` and that passing negative `depth` prints simplified value. Co-authored-by: Robin Drexler <drexler.robin@gmail.com> PR-URL: #24166 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8f18f0d - Browse repository at this point
Copy the full SHA 8f18f0dView commit details -
test: replace anonymous closure with arrow funct
PR-URL: #24439 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c15208c - Browse repository at this point
Copy the full SHA c15208cView commit details -
test: replace anonymous closure functions with arrow function
PR-URL: #24420 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fbb228b - Browse repository at this point
Copy the full SHA fbb228bView commit details -
test: replace anonymous closure functions with arrow functions
In `test/parallel/test-fs-truncate-fd.js`, callbacks use anonymous closure functions. It is safe to replace them with arrow functions since these callbacks don't alter their context (`this`). This results in shorter functions. PR-URL: #24478 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f19dae3 - Browse repository at this point
Copy the full SHA f19dae3View commit details -
src: elevate namespaces for repeated entities
PR-URL: #24475 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2565ff0 - Browse repository at this point
Copy the full SHA 2565ff0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 24acd53 - Browse repository at this point
Copy the full SHA 24acd53View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba1ebb4 - Browse repository at this point
Copy the full SHA ba1ebb4View commit details -
doc: edit COLLABORATOR_GUIDE.md on closing issues
Make the COLLABORATOR_GUIDE.md text on closing issues clearer. (Make it clear that all the text refers to issues *and* pull requests, etc.) PR-URL: #24477 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 672a31c - Browse repository at this point
Copy the full SHA 672a31cView commit details -
test: replace anonymous closure with arrow functions
PR-URL: #24481 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c45660f - Browse repository at this point
Copy the full SHA c45660fView commit details -
doc: add Ruben Bridgewater to release team
PR-URL: #23432 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for 1a74fad - Browse repository at this point
Copy the full SHA 1a74fadView commit details -
http2: throw from mapToHeaders
PR-URL: #24063 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Note: Landed with one collaborator approval after PR was open for 18 days
Configuration menu - View commit details
-
Copy full SHA for cd7df56 - Browse repository at this point
Copy the full SHA cd7df56View commit details -
Make the http2 binding a bit more efficient by setting the callback functions once when the module is loaded rather than for each `Http2Session` and `Http2Stream`. PR-URL: #24063 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Note: Landed with one collaborator approval after PR was open for 18 days
Configuration menu - View commit details
-
Copy full SHA for 81a7056 - Browse repository at this point
Copy the full SHA 81a7056View commit details -
http2: cleanup endStream logic
PR-URL: #24063 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Note: Landed with one collaborator approval after PR was open for 18 days
Configuration menu - View commit details
-
Copy full SHA for 5051e1b - Browse repository at this point
Copy the full SHA 5051e1bView commit details -
doc: move trott to tsc emeritus
(Effective after the next TSC meeting, November 21 2018.) I'm going to step away from TSC stuff for about 6 weeks. No exciting back-story here other than that I have a lot going on and I need a break. And I've also said that people should do exactly this more often. Maybe I'll make this an annual thing for me or something. While the decision of if and when to restore my TSC status is entirely up to the active members of the TSC, I intend to request to re-join in January. PR-URL: #24492 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 580eb5b - Browse repository at this point
Copy the full SHA 580eb5bView commit details -
test: refactor test-http-write-empty-string to use arrow functions
In `test/parallel/test-http-write-empty-string.js`, callbacks use anonymous closure functions. Replace them with arrow functions. PR-URL: #24483 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 4792bea - Browse repository at this point
Copy the full SHA 4792beaView commit details -
doc: add readable and writable property to Readable and Writable
PR-URL: #23933 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 41f2e36 - Browse repository at this point
Copy the full SHA 41f2e36View commit details -
Fix callback error reporting PR-URL: #24508 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 230eb0d - Browse repository at this point
Copy the full SHA 230eb0dView commit details -
doc: revise
author ready
explanationImprove the `author ready` text in the COLLABORATOR_GUIDE for scannability, readability, etc. PR-URL: #24558 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7463a7f - Browse repository at this point
Copy the full SHA 7463a7fView commit details -
build: fix Python detection when depot_tools are in PATH in Windows
PR-URL: #22539 Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e37c618 - Browse repository at this point
Copy the full SHA e37c618View commit details -
src: add include for standalone compile
- Include algorithm header in js_native_api_v8.cc since std::min requires it. - Add comments to js_native_api_v8_internals.h for NAPI_VERSION PR-URL: #24498 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b9bd4e9 - Browse repository at this point
Copy the full SHA b9bd4e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2245e5e - Browse repository at this point
Copy the full SHA 2245e5eView commit details -
test: replcae anonymous closure with arrow function
PR-URL: #24476 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for dbf14ce - Browse repository at this point
Copy the full SHA dbf14ceView commit details -
doc: clarify who may land on an LTS staging branch
Current language is a bit confusing PR-URL: #24465 Refs: #24344 (comment) Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4da44ad - Browse repository at this point
Copy the full SHA 4da44adView commit details -
test: replace callback with arrow functions
PR-URL: #24490 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for c4f16dd - Browse repository at this point
Copy the full SHA c4f16ddView commit details -
test: replace anonymous closure with arrow func
PR-URL: #24480 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b309dd2 - Browse repository at this point
Copy the full SHA b309dd2View commit details -
- Using arrow functions in test-tls-client-resume.js - Fixed error, Expected parentheses around arrow function argument arrow-parens PR-URL: #24436 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1cd73a8 - Browse repository at this point
Copy the full SHA 1cd73a8View commit details -
test: replace closure with arrow function
PR-URL: #24489 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for c28ec86 - Browse repository at this point
Copy the full SHA c28ec86View commit details -
test: refactor test to use arrow functions
In `test/parallel/test-cluster-send-deadlock.js`, callbacks use anonymous closure functions. It is safe to replace them with arrow functions since these callbacks don't contain references to `this`, `super` or `arguments`. This results in shorter functions. PR-URL: #24479 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 46b5df0 - Browse repository at this point
Copy the full SHA 46b5df0View commit details -
test: remove unused reject handlers
PR-URL: #24540 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Configuration menu - View commit details
-
Copy full SHA for 8fcf3b3 - Browse repository at this point
Copy the full SHA 8fcf3b3View commit details -
net,dgram: add ipv6Only option for net and dgram
For TCP servers, the dual-stack support is enable by default, i.e. binding host "::" will also make "0.0.0.0" bound. This commit add ipv6Only option in `net.Server.listen()` and `dgram.createSocket()` methods which allows to disable dual-stack support. Support for cluster module is also provided in this commit. Fixes: #17664 PR-URL: #23798 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a1254a3 - Browse repository at this point
Copy the full SHA a1254a3View commit details -
test: favor arrow function in callback
PR-URL: #24542 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 7b0292a - Browse repository at this point
Copy the full SHA 7b0292aView commit details -
test: replace anonymous function with arrow function
PR-URL: #24529 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 2c8c7b8 - Browse repository at this point
Copy the full SHA 2c8c7b8View commit details -
test: replace closure functions with arrow functions
PR-URL: #24522 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for e8c0fce - Browse repository at this point
Copy the full SHA e8c0fceView commit details -
test: change anonymous closure function to arrow function
PR-URL: #24433 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 9bf2659 - Browse repository at this point
Copy the full SHA 9bf2659View commit details -
deps: cherry-pick 073073b from upstream V8
Original commit message: [profiler] introduce API to enable detailed source positions This allows Node.js to enable detailed source positions for optimized code early on, without having to pass a flag string. R=petermarshall@chromium.org Change-Id: Ie74ea41f600cf6e31acbe802116df4976ccf1c75 Reviewed-on: https://chromium-review.googlesource.com/c/1319757 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#57380} Refs: v8/v8@073073b PR-URL: #24515 Refs: #24274 Refs: #24394 Refs: #24393 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Peter Marshall <petermarshall@chromium.org> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 61179e6 - Browse repository at this point
Copy the full SHA 61179e6View commit details -
src: enable detailed source positions in V8
PR-URL: #24515 Refs: #24274 Refs: #24394 Refs: #24393 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Peter Marshall <petermarshall@chromium.org> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for aa220cf - Browse repository at this point
Copy the full SHA aa220cfView commit details -
test: replace anonymous function with arrow func
PR-URL: #24525 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 759ed86 - Browse repository at this point
Copy the full SHA 759ed86View commit details -
test: add information to assertion
test-fs-stat-bigint.js failed once in CI but there wasn't enough information to know what was giong on. Adding a bit of information to the assertion that failed in case it fails again. PR-URL: #24566 Refs: #24565 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 765a81e - Browse repository at this point
Copy the full SHA 765a81eView commit details -
test: replace anonymous function with arrow
PR-URL: #24526 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 6b88541 - Browse repository at this point
Copy the full SHA 6b88541View commit details -
test: replace anonymous function with arrow
PR-URL: #24527 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 39adfc8 - Browse repository at this point
Copy the full SHA 39adfc8View commit details -
test: replace callback with arrow function
PR-URL: #24531 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2a67a49 - Browse repository at this point
Copy the full SHA 2a67a49View commit details -
n-api: handle reference delete before finalize
Crashes were reported during finalization due to the memory for a reference being deleted and the finalizer running after the deletion. This change ensures the deletion of the memory for the reference only occurs after the finalizer has run. Fixes: nodejs/node-addon-api#393 PR-URL: #24494 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0c51fc5 - Browse repository at this point
Copy the full SHA 0c51fc5View commit details -
test: replace callback with arrow functions
PR-URL: #24541 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 4070152 - Browse repository at this point
Copy the full SHA 4070152View commit details -
test: fix test case in test-child-process-fork-dgram.js
PR-URL: #24459 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 34b40af - Browse repository at this point
Copy the full SHA 34b40afView commit details -
test: use destructuring on require
PR-URL: #24455 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for 363d3c6 - Browse repository at this point
Copy the full SHA 363d3c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5796c6a - Browse repository at this point
Copy the full SHA 5796c6aView commit details -
test: replace callback with arrow functions
PR-URL: #24434 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for 1067653 - Browse repository at this point
Copy the full SHA 1067653View commit details -
doc: replace anonymous function with arrow function
PR-URL: #24627 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f80e7a1 - Browse repository at this point
Copy the full SHA f80e7a1View commit details -
PR-URL: #24590 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 657d7a5 - Browse repository at this point
Copy the full SHA 657d7a5View commit details -
doc: replace anonymous function with arrow function
PR-URL: #24617 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8d550f7 - Browse repository at this point
Copy the full SHA 8d550f7View commit details -
deps: cherry-pick 88f8fe1 from upstream V8
Original commit message: Fix collection iterator preview with deleted entries We used to assume that we know the remaining entries returned by the iterator based on the current index. However, that is not accurate, since entries skipped by the current index could be deleted. In the new approach, we allocate conservatively and shrink the result. R=neis@chromium.org Bug: v8:8433 Change-Id: I38a3004dc3af292daabb454bb76f38d65ef437e8 Reviewed-on: https://chromium-review.googlesource.com/c/1325966 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#57360} Refs: v8/v8@88f8fe1 PR-URL: #24514 Refs: #24053 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0afcb9a - Browse repository at this point
Copy the full SHA 0afcb9aView commit details -
doc: fix duplicate "this" and "the" on http2.md
PR-URL: #24611 Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 663d1c8 - Browse repository at this point
Copy the full SHA 663d1c8View commit details -
test: fix the arguments order in
assert.strictEqual
PR-URL: #24595 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 82ef618 - Browse repository at this point
Copy the full SHA 82ef618View commit details -
test: fix http2-binding strictEqual order
Switched the order of arguments for strictEqual checks inside of test/paralell/test-http2-binding.js PR-URL: #24616 Refs: nodejsjp#1 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for cd1aa2b - Browse repository at this point
Copy the full SHA cd1aa2bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 091238a - Browse repository at this point
Copy the full SHA 091238aView commit details -
crypto: allow monkey patching of pseudoRandomBytes
Make `pseudoRandomBytes` and it's aliases `prng` and `rng` configurable to allow monkey patching. PR-URL: #24108 Refs: #22519 Refs: #23017 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 16d7060 - Browse repository at this point
Copy the full SHA 16d7060View commit details -
test: fix arguments order in assert.strictEqual
PR-URL: #24591 Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 54778a0 - Browse repository at this point
Copy the full SHA 54778a0View commit details -
src: elevate v8 namespaces for node_url.cc
Elevate namespace for repeated entities. PR-URL: #24573 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8a91fc1 - Browse repository at this point
Copy the full SHA 8a91fc1View commit details -
PR-URL: #24619 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 12d7107 - Browse repository at this point
Copy the full SHA 12d7107View commit details -
test: cover path.basename when path and ext are the same
In path.basename was a case when the path and the extension is the same and this wasn't covered with tests. I covered this case both in Windows and Unix environments. PR-URL: #24570 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8849d80 - Browse repository at this point
Copy the full SHA 8849d80View commit details -
test: split out http2 from test-stream-pipeline
Splitting out the http2 portion of the test has a few benfits: * We don't skip the rest of the tests if `node` is compiled without crypto. * We can find out if the http2 portion of the test is responsible for the timeouts reported in issue 24456. Refs: #24456 PR-URL: #24631 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a701dfb - Browse repository at this point
Copy the full SHA a701dfbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3fa4def - Browse repository at this point
Copy the full SHA 3fa4defView commit details -
test: change anonymous function to arrow function
PR-URL: #24528 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7edea03 - Browse repository at this point
Copy the full SHA 7edea03View commit details -
test: convert callback to arrow function
PR-URL: #24513 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a82b420 - Browse repository at this point
Copy the full SHA a82b420View commit details -
lib: fix nits in lib/internal/bootstrap/cache.js
* Unwrap short lines. * Unify comments. * Decrease function calls. PR-URL: #24581 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 35a7646 - Browse repository at this point
Copy the full SHA 35a7646View commit details -
lib: simplify own keys retrieval
This replacement can save us a function call, two array spreadings, and an array concatenation. PR-URL: #24582 Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Reflect/ownKeys#Description Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b2c243f - Browse repository at this point
Copy the full SHA b2c243fView commit details -
tools: use print() function on both Python 2 and 3
PR-URL: #24486 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 23d8152 - Browse repository at this point
Copy the full SHA 23d8152View commit details -
doc: revise handling-own-pull-requests text
Simplify and clarify the text of the COLLABORATORS_GUIDE where handling one's own pull requests is concerned. PR-URL: #24583 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d4491a4 - Browse repository at this point
Copy the full SHA d4491a4View commit details -
doc: use arrow function for anonymous callbacks
PR-URL: #24606 Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for b65ffd5 - Browse repository at this point
Copy the full SHA b65ffd5View commit details -
lib: change anonymous function to arrow function
PR-URL: #24589 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a8e93f7 - Browse repository at this point
Copy the full SHA a8e93f7View commit details -
crypto: convert to arrow function
Changed function expression to arrow function. PR-URL: #24597 Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for c15efce - Browse repository at this point
Copy the full SHA c15efceView commit details -
src: replace new Array creation
PR-URL: #24601 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 955a8a7 - Browse repository at this point
Copy the full SHA 955a8a7View commit details -
test: fix arguments order in
assert.strictEqual
PR-URL: #24612 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for b7aa312 - Browse repository at this point
Copy the full SHA b7aa312View commit details -
Configuration menu - View commit details
-
Copy full SHA for dca1ecf - Browse repository at this point
Copy the full SHA dca1ecfView commit details -
lib: convert to arrow function
PR-URL: #24596 Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 59c2ee0 - Browse repository at this point
Copy the full SHA 59c2ee0View commit details -
build,src: sync src files with node.gyp
PR-URL: #24505 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for bd4df5b - Browse repository at this point
Copy the full SHA bd4df5bView commit details -
doc: clarify symlink resolution for __filename
Make it more explicit that symlinks are resolved in `__filename`. Refs: #22602 (comment) PR-URL: #24587 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5a47c2e - Browse repository at this point
Copy the full SHA 5a47c2eView commit details -
lib: suppress crypto related env vars in help msg
This commit adds a crypto check to suppress the crypto related environment variables introduced in Commit 399bb3c ("doc: add NODE_DEBUG_NATIVE to API docs"). Without this check, test/parallel/test-cli-node-print-help.js will fail when configured --without-ssl, as it some of the descriptions for these environment variables contain flags that the test is not expecting to find. PR-URL: #24556 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3df8633 - Browse repository at this point
Copy the full SHA 3df8633View commit details -
src: simplify uptime and ppid return values
This commit removes extraneous wrapping of return values in Uptime() and GetParentProcessId(). PR-URL: #24562 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jon Moss <me@jonathanmoss.me>
Configuration menu - View commit details
-
Copy full SHA for 9caad06 - Browse repository at this point
Copy the full SHA 9caad06View commit details -
lib: fix comment nits in bootstrap\loaders.js
PR-URL: #24641 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1063e0c - Browse repository at this point
Copy the full SHA 1063e0cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 955819e - Browse repository at this point
Copy the full SHA 955819eView commit details -
test: replace anonymous closure functions with arrow functions
PR-URL: #24443 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for abb1c64 - Browse repository at this point
Copy the full SHA abb1c64View commit details -
tools,doc: fix version picker bug in html.js
The processing of strings like `8.x` into a major version number and a minor version number results in minor versions that are `NaN`. In that situation, since the picker will link to the latest docs in the major version, include the version in the version picker. Fixes: #23979 PR-URL: #24638 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1625329 - Browse repository at this point
Copy the full SHA 1625329View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ebb32b - Browse repository at this point
Copy the full SHA 2ebb32bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d6fff0e - Browse repository at this point
Copy the full SHA d6fff0eView commit details -
test: fix argument order in assert.strictEqual
PR-URL: #24594 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3b99191 - Browse repository at this point
Copy the full SHA 3b99191View commit details -
stream: use arrow function for callback
In lib/internal/streams/async_iterator.js, use arrow function for callback. PR-URL: #24609 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 99b018b - Browse repository at this point
Copy the full SHA 99b018bView commit details -
test: update strictEqual argument order
PR-URL: #24622 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 99dbdca - Browse repository at this point
Copy the full SHA 99dbdcaView commit details -
doc: revise accepting-modifications in guide
Revise the "Accepting Modifications" section of the Collaborator Guide. PR-URL: #24650 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 85aa030 - Browse repository at this point
Copy the full SHA 85aa030View commit details -
test: use arrow functions in callbacks
PR-URL: #24441 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 9d54555 - Browse repository at this point
Copy the full SHA 9d54555View commit details -
Configuration menu - View commit details
-
Copy full SHA for 81b42d2 - Browse repository at this point
Copy the full SHA 81b42d2View commit details -
n-api,test: remove last argument in assert.strictEqual()
PR-URL: #24584 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7ef516a - Browse repository at this point
Copy the full SHA 7ef516aView commit details -
test: fix arguments order in
assert.strictEqual
PR-URL: #24621 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8072a2b - Browse repository at this point
Copy the full SHA 8072a2bView commit details -
lib: convert to Arrow Function
convert to Arrow Function and test by `./tools/test.py tick-processor` PR-URL: #24615 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e5c85ef - Browse repository at this point
Copy the full SHA e5c85efView commit details -
In `test/parallel/test-child-process-env.js`, callbacks use anonymous closure functions. It is safe to replace them with arrow functions since these callbacks don't contain references to `this`, `super` or `arguments`. This results in shorter functions. PR-URL: #24482 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0a492c7 - Browse repository at this point
Copy the full SHA 0a492c7View commit details -
doc: add antsmartian to collaborators
Fixes: #24340 PR-URL: #24655 Refs: #24340 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com>
Configuration menu - View commit details
-
Copy full SHA for 3288c27 - Browse repository at this point
Copy the full SHA 3288c27View commit details -
test: make test-uv-binding-constant JS engine neutral
The error message validation in test-uv-binding-constant depends on the JS engine. The text will be different in node-chakracore than in V8-based versions of Node.js. Remove the message validation. Test that it is a TypeError only. We should only validate error messages when we control the contents of that error message (and not even necessarily then, but that is a minimum requirement). V8 and other underlying engines can change the error message at any time and that should not require us to change our tests (as changing tests suggests a semver-major change). PR-URL: #24666 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 84249df - Browse repository at this point
Copy the full SHA 84249dfView commit details -
lib: convert to arrow function
PR-URL: #24623 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6f42b98 - Browse repository at this point
Copy the full SHA 6f42b98View commit details -
test: fix arguments order in assert.strictEqual
PR-URL: #24608 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f8acf73 - Browse repository at this point
Copy the full SHA f8acf73View commit details -
test: fix arguments order in
assert.strictEqual
PR-URL: #24607 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 992a904 - Browse repository at this point
Copy the full SHA 992a904View commit details
Commits on Nov 29, 2018
-
doc: fix nits in http(s) server.headersTimeout
* Fix sort orders of sections and bottom references. * Fix links. * Unify spelling. * Add missing YAML block. PR-URL: #24697 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b3e77a5 - Browse repository at this point
Copy the full SHA b3e77a5View commit details -
lib: rearm pre-existing signal event registrations
process.on('somesignal', ...) semantics expect the process to catch the signal and invoke the associated handler. `setupSignalHandlers` perform the additional task of preparing the libuv signal handler and associate it with the event handler. It is possible that by the time this is setup there could be pre-existing registrations that pre-date this setup in the boot sequence. So rearm pre-existing signal event registrations to get upto speed. Ref: #22712 (comment) PR-URL: #24651 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 83ab5f4 - Browse repository at this point
Copy the full SHA 83ab5f4View commit details -
src: use NativeModuleLoader to compile per_context.js
This patch introduces a NativeModuleLoader::CompileAndCall that can run a JS script under `lib/` as a function called with a null receiver and arguments specified from the C++ layer. Since all our bootstrappers are wrapped in functions in the source to avoid leaking variables into the global scope anyway, this allows us to remove that extra indentation in the JS source code. As a start we move the compilation and execution of per_context.js to NativeModuleLoader::CompileAndCall(). This patch also changes the return value of NativeModuleLoader::LookupAndCompile() to a MaybeLocal since the caller has to take care of the result being empty anyway. This patch reverts the previous design of having the NativeModuleLoader::Compile() method magically know about the parameters of the function - until we have tooling in-place to guess the parameter names in the source with some annotation, it's more readable to allow the caller to specify the parameters along with the arguments values. PR-URL: #24660 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
Configuration menu - View commit details
-
Copy full SHA for c708abb - Browse repository at this point
Copy the full SHA c708abbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e1c6eb - Browse repository at this point
Copy the full SHA 9e1c6ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 68dc100 - Browse repository at this point
Copy the full SHA 68dc100View commit details -
test: validate fs.rename() when NODE_TEST_DIR on separate mount
When testing fs.rename() of an non-existent file, use a destination path which is in the same directory. Otherwise we might trigger an `EXDEV` error if NODE_TEST_DIR is a separate device than the current working directory. Fixes: #21669 PR-URL: #24707 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 053f3d6 - Browse repository at this point
Copy the full SHA 053f3d6View commit details -
lib: chenged anonymous function to arrow function
PR-URL: #24605 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1c4bc86 - Browse repository at this point
Copy the full SHA 1c4bc86View commit details -
src: migrate to new V8 array API
This change migrates the deprecated V8 Array API to new APIs. PR-URL: #24613 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c26b10c - Browse repository at this point
Copy the full SHA c26b10cView commit details -
lib: change callbacks to arrow function
PR-URL: #24625 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 97b803f - Browse repository at this point
Copy the full SHA 97b803fView commit details -
test: reach res._dump after abort ClientRequest
PR-URL: #24191 Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e96c60e - Browse repository at this point
Copy the full SHA e96c60eView commit details -
lib: convert to arrow function in fs.js
PR-URL: #24604 Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for b1d3747 - Browse repository at this point
Copy the full SHA b1d3747View commit details -
PR-URL: #24618 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b554ff7 - Browse repository at this point
Copy the full SHA b554ff7View commit details -
src: simplify LibuvStreamWrap::DoWrite
PR-URL: #24588 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a122ba5 - Browse repository at this point
Copy the full SHA a122ba5View commit details -
test: fix the arguments order in
assert.strictEqual
PR-URL: #24626 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 969ae7a - Browse repository at this point
Copy the full SHA 969ae7aView commit details -
test: fix the arguments order in assert.strictEqual
I working at "Code and Learn" on Node fest 2018 in Japan. Refs: #24431 PR-URL: #24624 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 603bc27 - Browse repository at this point
Copy the full SHA 603bc27View commit details -
win, build: skip building cctest by default
vcbuild will build cctest only if it will be run, or for CI and release builds PR-URL: #21408 Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 899e7c3 - Browse repository at this point
Copy the full SHA 899e7c3View commit details -
build, tools, win: add .S files support to GYP
Makes GYP properly handle .S files. Fixes: nodejs/node-v8#89 PR-URL: #24553 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for 383d809 - Browse repository at this point
Copy the full SHA 383d809View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1035e36 - Browse repository at this point
Copy the full SHA 1035e36View commit details -
process: fix omitting
--
fromprocess.execArgv
This was essentially a typo that went unnoticed because we didn’t have tests for this particular situation. Fixes: #24647 PR-URL: #24654 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for effe307 - Browse repository at this point
Copy the full SHA effe307View commit details -
test: fix the arguments order in assert.strictEqual
PR-URL: #24620 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d5bf736 - Browse repository at this point
Copy the full SHA d5bf736View commit details -
http2: add compat support for nested array headers
writeHead supports an array of arrays containing header name and values. Compatibility between http2 & http1 even though this is not documented. Fixes: #24466 PR-URL: #24665 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 61e0103 - Browse repository at this point
Copy the full SHA 61e0103View commit details -
stream: make async iterator .next() always resolve
See: nodejs/readable-stream#387 PR-URL: #24668 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for b809fa8 - Browse repository at this point
Copy the full SHA b809fa8View commit details
Commits on Nov 30, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 654bd65 - Browse repository at this point
Copy the full SHA 654bd65View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7fbdf5 - Browse repository at this point
Copy the full SHA e7fbdf5View commit details
Commits on Dec 5, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 764d76f - Browse repository at this point
Copy the full SHA 764d76fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 66d8330 - Browse repository at this point
Copy the full SHA 66d8330View commit details -
process: refactor the bootstrap mode branching for readability
This patch refactors the branches for choosing the mode to run Node.js in `internal/bootstrap/node.js`. Instead of inlining the decision making all in `startup`, we create a `startExecution()` function which either detects and start the non-user-code mode, or prepares for user code execution (worker setup, preloading modules) and starts user code execution. We use early returns when we decide the mode to run Node.js in for fewer indentations and better readability. This patch also adds a few comments about the command-line switches and a few TODOs to remove underscore properties on `process` that are mainly used for bootstrap mode branching. It also includes a few other refactoring such as inlining functions/variables that are not reused and removing the default argument of `evalScript` for better clarity. PR-URL: #24673 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5874a03 - Browse repository at this point
Copy the full SHA 5874a03View commit details -
src: remove unused variables in node_util.cc
Currently two warnings are generated regarding unused variables. This commit removes the unused variables. PR-URL: #24717 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 87c864c - Browse repository at this point
Copy the full SHA 87c864cView commit details -
test: use arrow syntax for anonymous callbacks
PR-URL: #24691 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 0894899 - Browse repository at this point
Copy the full SHA 0894899View commit details -
lib: move setupAllowedFlags() into per_thread.js
Because most of its code (the getter) has nothing to do with the actual bootstrapping and it is run per-thread. PR-URL: #24704 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Christopher Hiller <boneskull@boneskull.com>
Configuration menu - View commit details
-
Copy full SHA for d77cf92 - Browse repository at this point
Copy the full SHA d77cf92View commit details -
test: cover path empty string case
In path.toNamespacePath was a case when the path was empty string and it wasn't covered in the tests. I covered this case both in Windows and Unix environments. PR-URL: #24569 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3c3ebe5 - Browse repository at this point
Copy the full SHA 3c3ebe5View commit details -
test: verify order of error in h2 server stream
Currently the order of error / closing of an h2 stream is consistent in 10.x, 11.x, and master. There appears to be an unexpected behavior difference in 8.x. This test will be used to bisect the commit that will fix this behavior change and ensure there are no future regressions. PR-URL: #24685 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8ffe04f - Browse repository at this point
Copy the full SHA 8ffe04fView commit details -
This is a change from the ecmascript-modules fork. There is no change to behavior and we would like to upstream to reduce the delta between our repos. Refs: https://github.com/nodejs/ecmascript-modules#9 PR-URL: #24560 Refs: nodejs/ecmascript-modules#9 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
Configuration menu - View commit details
-
Copy full SHA for 1743568 - Browse repository at this point
Copy the full SHA 1743568View commit details -
lib: do not register DOMException in a module
Instead of registering it in a global scope of a native module and expecting that it only gets evaluated when the module is actually compiled and run and will not be evaluated because the module can be cached, directly register the DOMException constructor onto Environment during bootstrap for clarity, since this is a side effect that has to happen during bootstrap. PR-URL: #24708 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for eab981e - Browse repository at this point
Copy the full SHA eab981eView commit details -
src: move C++ binding/addon related code into node_binding{.h, .cc}
This patch: - Moves the C++ binding/addon related code out of node_internals.h/node.cc and into dedicated files node_binding.h/node_binding.cc, and only puts the code resued by other files into the header. - Introduce a node::binding namespace so that code exposed to other files can be easily recognized. PR-URL: #24701 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for f31292d - Browse repository at this point
Copy the full SHA f31292dView commit details -
src: elevate v8 namespaces referenced
PR-URL: #24657 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0148c1d - Browse repository at this point
Copy the full SHA 0148c1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 10c2773 - Browse repository at this point
Copy the full SHA 10c2773View commit details -
src: remove unused context variable in node_serdes
Currently the following compiler warnings is generated: ../src/node_serdes.cc:400:18: warning: unused variable 'context' [-Wunused-variable] Local<Context> context = ctx->env()->context(); ^ 1 warning generated. This commit removes the unused variable. PR-URL: #24713 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f28fdc9 - Browse repository at this point
Copy the full SHA f28fdc9View commit details -
src: elevate v8 namespaces for node_process.cc
Elevate namespace for repeated entities. Resolved conflicts. PR-URL: #24578 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 193f315 - Browse repository at this point
Copy the full SHA 193f315View commit details -
tools: check for git tag before promoting release
PR-URL: #24670 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2ef6aed - Browse repository at this point
Copy the full SHA 2ef6aedView commit details -
tools: only sign release if promotion successful
Ref: nodejs/build#1596 PR-URL: #24669 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e3649c8 - Browse repository at this point
Copy the full SHA e3649c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e5a79a - Browse repository at this point
Copy the full SHA 9e5a79aView commit details -
url: use SafeSet to filter known special protocols
Avoids a maintenance hazard when reviewers assume that `hostlessProtocol` and `slashedProtocol` are disjoint. The following may be counter-intuitive: ```js // These objects seem to have no keys in common const hostlessProtocol = { 'javascript': true }; const slashedProtocol = { 'http': true }; // A reasonable reviewer may assumes bothTrue is never truthy function bothTrue(lowerProto) { return hostlessProtocol[lowerProto] && slashedProtocol[lowerProto]; } // But console.log(Boolean(bothTrue('constructor'))); // true ``` This change uses SafeSet instead of plain-old objects. ---- Rejected alternative: We could have used object with a `null` prototype as lookup tables so that `lowerProto` is never treated as a key into `Object.prototype`. ```js const hostlessProtocol = { __proto__: null, 'javascript': true }; const slashedProtocol = { __proto__: null, 'http': true }; function bothTrue(lowerProto) { return hostlessProtocol[lowerProto] && slashedProtocol[lowerProto]; } console.log(Boolean(bothTrue('constructor'))); // false ``` PR-URL: #24703 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for be54dc0 - Browse repository at this point
Copy the full SHA be54dc0View commit details -
build: fix c++ code coverage on macOS
PR-URL: #24520 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for 3fe4498 - Browse repository at this point
Copy the full SHA 3fe4498View commit details -
timers: fix setTimeout expiration logic
Fix the timer logic to be the same as v10.30.0. Fixes: #24203 PR-URL: #24214 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Configuration menu - View commit details
-
Copy full SHA for d2e9b76 - Browse repository at this point
Copy the full SHA d2e9b76View commit details -
Revert "url: make the context non-enumerable"
This reverts commit 5e1bf05, as it causes major performance regressions during object construction. Refs: #24218 PR-URL: #24495 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 96e6873 - Browse repository at this point
Copy the full SHA 96e6873View commit details -
src: set HAS_USERNAME/PASSWORD more strictly
Fixes: #24211 PR-URL: #24495 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0e88f44 - Browse repository at this point
Copy the full SHA 0e88f44View commit details -
url: reuse existing context in href setter
Correctness-wise, this removes side effects in the href setter if parsing fails. Style-wise, this allows removing the parse() wrapper function around C++ _parse(). Also fix an existing bug with whitespace trimming in C++ that was previously circumvented by additionally trimming the input in JavaScript. Fixes: #24345 Refs: #24218 (comment) PR-URL: #24495 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0d7ee19 - Browse repository at this point
Copy the full SHA 0d7ee19View commit details -
url: simplify native URL object construction
Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com> PR-URL: #24495 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 540929d - Browse repository at this point
Copy the full SHA 540929dView commit details -
test: minor refactoring of onticketkeycallback
The motivation for this commit is to make the the onticketkeycallback function more readable. PR-URL: #24718 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 026e03c - Browse repository at this point
Copy the full SHA 026e03cView commit details -
src: use arraysize instead of hardcode number
PR-URL: #24473 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ecbe616 - Browse repository at this point
Copy the full SHA ecbe616View commit details -
doc: cookie is joined using '; '
document that incoming cookie headers are joined using '; '. PR-URL: #24740 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 25e5164 - Browse repository at this point
Copy the full SHA 25e5164View commit details -
test: show stdout and stderr in test-cli-syntax when it fails
Configuration menu - View commit details
-
Copy full SHA for 085f5b6 - Browse repository at this point
Copy the full SHA 085f5b6View commit details -
http: fix error return in
Finish()
`http_parser_execute(..., nullptr, 0)` returns either `0` or `1`. The expectation is that no error must be returned if it is `0`, and if it is `1` - a `Error` object must be returned back to user. The introduction of `llhttp` and the refactor that happened during it accidentally removed the error-returning code. This commit reverts it back to its original state. Fix: #24585 PR-URL: #24738 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3fe3bc9 - Browse repository at this point
Copy the full SHA 3fe3bc9View commit details -
http2: make compat writeHead not crash if the stream is destroyed
Configuration menu - View commit details
-
Copy full SHA for 798504a - Browse repository at this point
Copy the full SHA 798504aView commit details -
build: fix line length off by one error
While running the test suite the progress bar shows former line endings if the new line is shorter than the former line. The length was calculated without the line ending. It is now an empty string to prevent the off by one error instead of using extra whitespace. PR-URL: #24748 Refs: #24486 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for e0e15da - Browse repository at this point
Copy the full SHA e0e15daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b71099 - Browse repository at this point
Copy the full SHA 6b71099View commit details -
Configuration menu - View commit details
-
Copy full SHA for 12feb9e - Browse repository at this point
Copy the full SHA 12feb9eView commit details -
test: increase assert test coverage
PR-URL: #24745 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 2916b59 - Browse repository at this point
Copy the full SHA 2916b59View commit details -
test: check invalid argument error for option
This commit adds a test for the validateArguments function in TextDecoder. PR-URL: #24736 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7577e75 - Browse repository at this point
Copy the full SHA 7577e75View commit details -
util,console: handle symbols as defined in the spec
The `console` functions rely on the `util.format()` behavior. It did not follow the whatwg spec when it comes to symbols in combination with the %d, %i and %f format specifiers. Using a symbol argument in combination with one of these specifiers resulted in an error instead of returning `'NaN'`. This is now fixed by this patch. PR-URL: #23708 Refs: https://console.spec.whatwg.org/#formatter Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for e13571c - Browse repository at this point
Copy the full SHA e13571cView commit details -
util: improve internal
isError()
validationThe current internal isError function checked the toString value instead of using the more precise `util.types.isNativeError()` check. The `instanceof` check is not removed due to possible errors that are not native but still an instance of Error. PR-URL: #24746 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 807c108 - Browse repository at this point
Copy the full SHA 807c108View commit details -
tools: fix eslint usage for Node.js 8 and before
IDEs like vscode use older Node.js versions that do not yet support the new try catch syntax. This makes sure eslint continues to work in these IDEs as before. PR-URL: #24753 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 09cd2ec - Browse repository at this point
Copy the full SHA 09cd2ecView commit details -
doc: add missing changes entry
The `util.format()` behavior changed recently. Add the changes entry to document the new BigInt behavior. PR-URL: #24758 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4d41c8f - Browse repository at this point
Copy the full SHA 4d41c8fView commit details -
assert: fix loose deepEqual map comparison
Loose map comparison had an logic error. It will now be properly compared. PR-URL: #24749 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7fb8d31 - Browse repository at this point
Copy the full SHA 7fb8d31View commit details -
assert,util: fix sparse array comparison
Comparing sparse arrays did not work properly. That is fixed and tests were added to verify that everything works as expected. This had an impact on `util.isDeepStrictEqual()` and `assert.deepStrictEqual()` and their counterpart `assert.notDeepStrictEqual()`. PR-URL: #24749 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8905518 - Browse repository at this point
Copy the full SHA 8905518View commit details -
test: improve comparison coverage to 100%
PR-URL: #24749 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5f58928 - Browse repository at this point
Copy the full SHA 5f58928View commit details -
src: use custom TryCatch subclass
PR-URL: #24751 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c957adb - Browse repository at this point
Copy the full SHA c957adbView commit details -
doc: fix REPLACEME for tls min/max protocol option
Fill in correct pr-url: value in the YAML changelog that was missing from f512f5e. The stanza was also sorted in the wrong order, most recent is supposed to be in the beginning of the changes, not the end. PR-URL: #24759 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 06011f5 - Browse repository at this point
Copy the full SHA 06011f5View commit details -
doc: make release README link be consistent with text
PR-URL: #24783 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c09ea83 - Browse repository at this point
Copy the full SHA c09ea83View commit details -
doc: streamline Accepting Modifications in Collaborator Guide
Editing a sentence I missed simplifying in the last pass on that section. PR-URL: #24807 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 751d961 - Browse repository at this point
Copy the full SHA 751d961View commit details -
doc: fix added version of randomFill+randomFillSync
PR-URL: #24812 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 58e5c00 - Browse repository at this point
Copy the full SHA 58e5c00View commit details -
doc: hide undocumented object artifacts in async_hooks
The examples show `process.stdout.fd` as a means to use synchronous writes in async_hooks context. However this is an undocumented field, so showcase a file write example instead. Fixes: #22873 PR-URL: #24741 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 997c0e0 - Browse repository at this point
Copy the full SHA 997c0e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f8787c - Browse repository at this point
Copy the full SHA 1f8787cView commit details -
src: move READONLY_* macros into util.h
Move these macros to util.h so they can be shared among different C++ files. Also, renames `READONLY_BOOLEAN_PROPERTY` to `READONLY_TRUE_PROPERTY` (since it sets the property to true), and use `ToV8Value` in `READONLY_STRING_PROPERTY`. PR-URL: #24774 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 53b59b4 - Browse repository at this point
Copy the full SHA 53b59b4View commit details -
src: move version metadata into node_metadata{.h, .cc}
This patch moves the computation of version metadata from node.cc into node_metadata{.h, .cc}, and creates a macro that can be used to iterate over the available version keys (v8, uv, .etc). This makes the code clearer as now we no longer need to add all the headers in node.cc just to compute the versions, and makes it easier to reuse the version definitions. PR-URL: #24774 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7c70b61 - Browse repository at this point
Copy the full SHA 7c70b61View commit details -
test: add flag scenario in test-fs-write-file-sync
fs.writeFileSync takes flag param to define the file opening semantics. Add a scenario that covers flags as well. PR-URL: #24766 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9572008 - Browse repository at this point
Copy the full SHA 9572008View commit details -
src: fix type mismatch warnings from missing priv
Registration initialization functions are expected to have a 4th argument, a void*, so add them where necessary to fix the warnings. PR-URL: #24737 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5bd33f1 - Browse repository at this point
Copy the full SHA 5bd33f1View commit details -
lib: remove duplicated noop function
PR-URL: #24770 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Weijia Wang <starkwang@126.com>
Configuration menu - View commit details
-
Copy full SHA for 1ec4f8d - Browse repository at this point
Copy the full SHA 1ec4f8dView commit details -
test: check for the correct strict equal arguments order
This activates a eslint rule to verify that the `assert.strictEqual()` arguments are in the correct order. PR-URL: #24752 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a7a1cb4 - Browse repository at this point
Copy the full SHA a7a1cb4View commit details -
test: use ES2017 syntax in test-fs-open-*
Update test-fs-open-flags to take advantage of destructuring and default values. Update test-fs-open-mode-mask to use a ternary to make use of a constant possible. PR-URL: #23031 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cc133c4 - Browse repository at this point
Copy the full SHA cc133c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d1853b - Browse repository at this point
Copy the full SHA 3d1853bView commit details -
test: fix
common.mustNotCall()
usage in HTTP testThe argument to `common.mustNotCall()` is a message, not a function. PR-URL: #24750 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 63b06b5 - Browse repository at this point
Copy the full SHA 63b06b5View commit details -
fs: simplify fs.promises warning logic
fs.promises is lazy loaded. Instead of using a seaparate Boolean flag to track whether or not it has been loaded, just inspect the state of the lazy loaded module itself. PR-URL: #24788 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Configuration menu - View commit details
-
Copy full SHA for 124fca0 - Browse repository at this point
Copy the full SHA 124fca0View commit details -
dns: simplify dns.promises warning logic
dns.promises is lazy loaded. Instead of using a seaparate Boolean flag to track whether or not it has been loaded, just inspect the state of the lazy loaded module itself. PR-URL: #24788 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2dfaa48 - Browse repository at this point
Copy the full SHA 2dfaa48View commit details
Commits on Dec 7, 2018
-
doc: revise code review guidelines
Revise the Code Reviews section of the Collaborator Guide to remove redundant statements, simplify text and structure for easier comprehension, and remove material that does not reflect current practices. PR-URL: #24790 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 566046c - Browse repository at this point
Copy the full SHA 566046cView commit details -
Partition test/addons-napi into test/js-native-api and test/node-api to isolate the Node.js-agnostic portion of the N-API tests from the Node.js-specific portion. PR-URL: #24557 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c227b1b - Browse repository at this point
Copy the full SHA c227b1bView commit details -
build: make tar.xz creation opt-out, fail if no xz
PR-URL: #24551 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 3a24c91 - Browse repository at this point
Copy the full SHA 3a24c91View commit details -
doc: use author's titles for linked resources
Update Collaborator Guide links to use the title of the item being linked. PR-URL: #24837 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Configuration menu - View commit details
-
Copy full SHA for b8611a3 - Browse repository at this point
Copy the full SHA b8611a3View commit details -
doc: add triaging section to releases.md
Add a section on triaging commits and PRs to land in releases. PR-URL: #20165 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 162b3a1 - Browse repository at this point
Copy the full SHA 162b3a1View commit details -
test: add .gitignore file for node-api
Refs: #24557 (comment) PR-URL: #24839 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7069ed7 - Browse repository at this point
Copy the full SHA 7069ed7View commit details -
test: remove unused addons-napi directory
Refs: #24557 (comment) PR-URL: #24839 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0ed669c - Browse repository at this point
Copy the full SHA 0ed669cView commit details -
build: fix check-xz for platforms defaulting to sh
5e80a9a introduced check-xz, using `[[ .. ]]` syntax, but this is a bash builtin and some platforms default to `sh` when doing `$(shell ...)` in Makefiles. Fix is to make it sh friendly. Ref: #24551 PR-URL: #24841 Refs: #24551 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for bfec6a4 - Browse repository at this point
Copy the full SHA bfec6a4View commit details -
tls: add min/max protocol version options
The existing secureProtocol option only allows setting the allowed protocol to a specific version, or setting it to "all supported versions". It also used obscure strings based on OpenSSL C API functions. Directly setting the min or max is easier to use and explain. Backport-PR-URL: #24676 PR-URL: #24405 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
Configuration menu - View commit details
-
Copy full SHA for acb7351 - Browse repository at this point
Copy the full SHA acb7351View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b78d2c - Browse repository at this point
Copy the full SHA 5b78d2cView commit details -
Revert "util: change util.inspect depth default"
This reverts commit ac7450a. This fully reverts the changes to util.inspect depth. It has caused breakage in logging to existing apps, and even something as simple as `console.log(require)` will cause >1m freezes. I've heard nothing but negative feedback (seriously not a single person has expressed anything positive about this change) and personally i find this change extremely annoying.
Configuration menu - View commit details
-
Copy full SHA for 5a853a0 - Browse repository at this point
Copy the full SHA 5a853a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 88a5449 - Browse repository at this point
Copy the full SHA 88a5449View commit details -
Configuration menu - View commit details
-
Copy full SHA for 71e520c - Browse repository at this point
Copy the full SHA 71e520cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d9a265 - Browse repository at this point
Copy the full SHA 4d9a265View commit details -
tools: replace rollup with ncc
Replace rollup + plugins + config file with zeit/ncc package designed to do the particular task that we're leveraging rollup for but with zero-ish configuration. (rollup can do a whole lot more, but we're using a tiny portion of its functionality.) PR-URL: #24813 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 1ea01c5 - Browse repository at this point
Copy the full SHA 1ea01c5View commit details -
buffer: remove checkNumberType()
checkNumberType() was a very thin wrapper around validateNumber(). This commit removes checkNumberType() and used validateNumber() directly instead. PR-URL: #24815 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 73786c8 - Browse repository at this point
Copy the full SHA 73786c8View commit details -
doc: list all versions WHATWG URL api was added
PR-URL: #24847 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d800998 - Browse repository at this point
Copy the full SHA d800998View commit details -
doc: mention util depth default change
This was missed when reverting a former commit. To make sure the history is kept in place, this just adds a new entry to state the revert. PR-URL: #24805 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 5a1fb1e - Browse repository at this point
Copy the full SHA 5a1fb1eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d881b33 - Browse repository at this point
Copy the full SHA d881b33View commit details -
lib: remove some useless assignments
PR-URL: #23199 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 6c8a73d - Browse repository at this point
Copy the full SHA 6c8a73dView commit details -
build,win: pack the install-tools scripts for dist
PR-URL: #24233 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com>
Configuration menu - View commit details
-
Copy full SHA for 706bc41 - Browse repository at this point
Copy the full SHA 706bc41View commit details -
build: add '.git' to 'make lint-py' exclude list
When run locally [flake8](http://flake8.pycqa.org) was creating false positives by scanning the __.git__ directory. This PR prevents that behavior. PR-URL: #24802 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a22ac0b - Browse repository at this point
Copy the full SHA a22ac0bView commit details -
http: make parser choice a runtime flag
Add a `--http-parser=llhttp` vs `--http-parser=traditional` command line switch, to make testing and comparing the new llhttp-based implementation easier. PR-URL: #24739 Refs: #24730 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Configuration menu - View commit details
-
Copy full SHA for c8d5e31 - Browse repository at this point
Copy the full SHA c8d5e31View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6fed6f5 - Browse repository at this point
Copy the full SHA 6fed6f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 73bc5fd - Browse repository at this point
Copy the full SHA 73bc5fdView commit details -
tools: prepare tools/install.py for Python 3
PR-URL: #24800 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for 249c143 - Browse repository at this point
Copy the full SHA 249c143View commit details -
2018-12-07, Version 11.4.0 (Current)
Notable Changes: * console,util: * `console` functions now handle symbols as defined in the spec. #23708 * The inspection `depth` default is now back at 2. #24326 * dgram,net: * Added ipv6Only option for `net` and `dgram`. #23798 * http: * Chosing between the http parser is now possible per runtime flag. #24739 * readline: * The `readline` module now supports async iterators. #23916 * repl: * The multiline history feature is removed. #24804 * tls: * Added min/max protocol version options. #24405 * The X.509 public key info now includes the RSA bit size and the elliptic curve. #24358 * url: * `pathToFileURL()` now supports LF, CR and TAB. #23720 * Windows: * Tools are not installed using Boxstarter anymore. #24677 * The install-tools scripts or now included in the dist. #24233 * Added new collaborator: * [antsmartian](https://github.com/antsmartian) - Anto Aravinth. #24655 PR-URL: #24854
Configuration menu - View commit details
-
Copy full SHA for 4f1297f - Browse repository at this point
Copy the full SHA 4f1297fView commit details