From 19982da37acd68c4fcca1337bac12cb222200218 Mon Sep 17 00:00:00 2001 From: Myles Borins Date: Fri, 18 Jan 2019 12:06:26 -0500 Subject: [PATCH 1/2] doc: add note regarding pushing release tags Tags shouldn't be pushed unless the remainder of release steps are able to be completed. --- doc/releases.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/doc/releases.md b/doc/releases.md index 117edc4a780b92..0586e2174bf4a7 100644 --- a/doc/releases.md +++ b/doc/releases.md @@ -437,7 +437,7 @@ install the new build. Make sure that the build appears correct. Check the version numbers, and perform some basic checks to confirm that all is well with the build before moving forward. -### 11. Tag and Sign the Release Commit +### 11. Tag and Sign the Release Commit Once you have produced builds that you're happy with, create a new tag. By waiting until this stage to create tags, you can discard a proposed release if @@ -473,6 +473,9 @@ following command: $ git push ``` +*Note*: Please do not push the tag unless you are ready to complete the remainder of the release +steps 12 - 19 + ### 12. Set Up For the Next Release On release proposal branch, edit `src/node_version.h` again and: From d56e9a5cf50b61062852159ca7e7fb2e30a770df Mon Sep 17 00:00:00 2001 From: Myles Borins Date: Wed, 23 Jan 2019 12:31:39 -0500 Subject: [PATCH 2/2] fix nits --- doc/releases.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/releases.md b/doc/releases.md index 0586e2174bf4a7..5c4eb94312b33a 100644 --- a/doc/releases.md +++ b/doc/releases.md @@ -437,7 +437,7 @@ install the new build. Make sure that the build appears correct. Check the version numbers, and perform some basic checks to confirm that all is well with the build before moving forward. -### 11. Tag and Sign the Release Commit +### 11. Tag and Sign the Release Commit Once you have produced builds that you're happy with, create a new tag. By waiting until this stage to create tags, you can discard a proposed release if @@ -473,8 +473,8 @@ following command: $ git push ``` -*Note*: Please do not push the tag unless you are ready to complete the remainder of the release -steps 12 - 19 +*Note*: Please do not push the tag unless you are ready to complete the +remainder of the release steps. ### 12. Set Up For the Next Release