From ec6bcaab1e1ac10338410a241e3703796392c6d9 Mon Sep 17 00:00:00 2001 From: gengjiawen Date: Mon, 11 Feb 2019 17:20:52 +0800 Subject: [PATCH] src: apply clang-tidy rule performance-unnecessary-value-param --- src/env-inl.h | 6 ++++-- src/env.h | 7 ++++--- src/node_crypto.cc | 2 +- src/node_messaging.cc | 2 +- src/node_messaging.h | 2 +- src/node_perf.cc | 2 +- src/node_url.h | 8 ++++---- src/sharedarraybuffer_metadata.cc | 4 +++- src/util.h | 3 ++- test/cctest/test_inspector_socket_server.cc | 8 ++++---- 10 files changed, 25 insertions(+), 19 deletions(-) diff --git a/src/env-inl.h b/src/env-inl.h index 60dafc04e16516..b115f9686b7e4d 100644 --- a/src/env-inl.h +++ b/src/env-inl.h @@ -37,6 +37,8 @@ #include #include +#include + namespace node { inline v8::Isolate* IsolateData::isolate() const { @@ -395,7 +397,7 @@ inline uv_loop_t* Environment::event_loop() const { inline void Environment::TryLoadAddon( const char* filename, int flags, - std::function was_loaded) { + const std::function& was_loaded) { loaded_addons_.emplace_back(filename, flags); if (!was_loaded(&loaded_addons_.back())) { loaded_addons_.pop_back(); @@ -597,7 +599,7 @@ inline std::shared_ptr IsolateData::options() { inline void IsolateData::set_options( std::shared_ptr options) { - options_ = options; + options_ = std::move(options); } void Environment::CreateImmediate(native_immediate_callback cb, diff --git a/src/env.h b/src/env.h index 0228b2d9d02a5f..7e64db02d192b8 100644 --- a/src/env.h +++ b/src/env.h @@ -657,9 +657,10 @@ class Environment { inline v8::Isolate* isolate() const; inline uv_loop_t* event_loop() const; - inline void TryLoadAddon(const char* filename, - int flags, - std::function was_loaded); + inline void TryLoadAddon( + const char* filename, + int flags, + const std::function& was_loaded); static inline Environment* from_timer_handle(uv_timer_t* handle); inline uv_timer_t* timer_handle(); diff --git a/src/node_crypto.cc b/src/node_crypto.cc index 9bd557f9ac3f69..aaba05b984f54f 100644 --- a/src/node_crypto.cc +++ b/src/node_crypto.cc @@ -2712,7 +2712,7 @@ static ParsePublicKeyResult TryParsePublicKey( const BIOPointer& bp, const char* name, // NOLINTNEXTLINE(runtime/int) - std::function parse) { + const std::function& parse) { unsigned char* der_data; long der_len; // NOLINT(runtime/int) diff --git a/src/node_messaging.cc b/src/node_messaging.cc index 896f43cd23d372..13581808ed5e19 100644 --- a/src/node_messaging.cc +++ b/src/node_messaging.cc @@ -147,7 +147,7 @@ MaybeLocal Message::Deserialize(Environment* env, } void Message::AddSharedArrayBuffer( - SharedArrayBufferMetadataReference reference) { + const SharedArrayBufferMetadataReference& reference) { shared_array_buffers_.push_back(reference); } diff --git a/src/node_messaging.h b/src/node_messaging.h index 3c79e24f24b896..636091e84edf69 100644 --- a/src/node_messaging.h +++ b/src/node_messaging.h @@ -43,7 +43,7 @@ class Message : public MemoryRetainer { // Internal method of Message that is called when a new SharedArrayBuffer // object is encountered in the incoming value's structure. - void AddSharedArrayBuffer(SharedArrayBufferMetadataReference ref); + void AddSharedArrayBuffer(const SharedArrayBufferMetadataReference& ref); // Internal method of Message that is called once serialization finishes // and that transfers ownership of `data` to this message. void AddMessagePort(std::unique_ptr&& data); diff --git a/src/node_perf.cc b/src/node_perf.cc index b9c0183a83d930..f9c9931e09b7a3 100644 --- a/src/node_perf.cc +++ b/src/node_perf.cc @@ -182,7 +182,7 @@ void ClearMark(const FunctionCallbackInfo& args) { } } -inline uint64_t GetPerformanceMark(Environment* env, std::string name) { +inline uint64_t GetPerformanceMark(Environment* env, const std::string& name) { auto marks = env->performance_marks(); auto res = marks->find(name); return res != marks->end() ? res->second : 0; diff --git a/src/node_url.h b/src/node_url.h index 47b859b879bca4..e85b14e2bdf35c 100644 --- a/src/node_url.h +++ b/src/node_url.h @@ -109,16 +109,16 @@ class URL { } } - explicit URL(std::string input) : + explicit URL(const std::string& input) : URL(input.c_str(), input.length()) {} - URL(std::string input, const URL* base) : + URL(const std::string& input, const URL* base) : URL(input.c_str(), input.length(), base) {} - URL(std::string input, const URL& base) : + URL(const std::string& input, const URL& base) : URL(input.c_str(), input.length(), &base) {} - URL(std::string input, std::string base) : + URL(const std::string& input, const std::string& base) : URL(input.c_str(), input.length(), base.c_str(), base.length()) {} int32_t flags() { diff --git a/src/sharedarraybuffer_metadata.cc b/src/sharedarraybuffer_metadata.cc index 4e6f5a349d1d57..5c58fac3ccf257 100644 --- a/src/sharedarraybuffer_metadata.cc +++ b/src/sharedarraybuffer_metadata.cc @@ -1,4 +1,6 @@ #include "sharedarraybuffer_metadata.h" + +#include #include "base_object.h" #include "base_object-inl.h" #include "node_errors.h" @@ -43,7 +45,7 @@ class SABLifetimePartner : public BaseObject { Local obj, SharedArrayBufferMetadataReference r) : BaseObject(env, obj), - reference(r) { + reference(std::move(r)) { MakeWeak(); } diff --git a/src/util.h b/src/util.h index b199476aa246bf..312f91e68e8b97 100644 --- a/src/util.h +++ b/src/util.h @@ -40,6 +40,7 @@ #include #include #include +#include namespace node { @@ -450,7 +451,7 @@ template inline void USE(T&&) {} struct OnScopeLeave { std::function fn_; - explicit OnScopeLeave(std::function fn) : fn_(fn) {} + explicit OnScopeLeave(std::function fn) : fn_(std::move(fn)) {} ~OnScopeLeave() { fn_(); } }; diff --git a/test/cctest/test_inspector_socket_server.cc b/test/cctest/test_inspector_socket_server.cc index 349356ef56c9fc..194f05f8ed5df3 100644 --- a/test/cctest/test_inspector_socket_server.cc +++ b/test/cctest/test_inspector_socket_server.cc @@ -92,7 +92,7 @@ class SocketWrapper { connected_(false), sending_(false) { } - void Connect(std::string host, int port, bool v6 = false) { + void Connect(const std::string& host, int port, bool v6 = false) { closed_ = false; connection_failed_ = false; connected_ = false; @@ -114,7 +114,7 @@ class SocketWrapper { ReadCallback); } - void ExpectFailureToConnect(std::string host, int port) { + void ExpectFailureToConnect(const std::string& host, int port) { connected_ = false; connection_failed_ = false; closed_ = false; @@ -243,7 +243,7 @@ class ServerHolder { : ServerHolder(has_targets, loop, HOST, port, nullptr) { } ServerHolder(bool has_targets, uv_loop_t* loop, - const std::string host, int port, FILE* out); + const std::string& host, int port, FILE* out); InspectorSocketServer* operator->() { return server_.get(); @@ -350,7 +350,7 @@ class TestSocketServerDelegate : public SocketServerDelegate { }; ServerHolder::ServerHolder(bool has_targets, uv_loop_t* loop, - const std::string host, int port, FILE* out) { + const std::string& host, int port, FILE* out) { std::vector targets; if (has_targets) targets = { MAIN_TARGET_ID };